Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flag from language dropdown #5246

Open
wants to merge 2 commits into
base: master
from

Conversation

@Goosly
Copy link
Contributor

Goosly commented Mar 6, 2020

fixes #5245 (maybe, I've not yet succeeded in getting the project running locally so I can't test)

Goosly and others added 2 commits Mar 6, 2020
merge master to my fork
Manu
Copy link
Member

jonatanklosko left a comment

LGTM, but please ensure that it works locally.

@@ -14,7 +14,7 @@
<div class="panel-heading <%= class_heading %>" data-toggle="collapse" data-target="#collapse-<%= locale %>">
<h3 class="panel-title">
<span class="label label-<%= class_panel %>">i18n</span>
<span class="label label-<%= class_panel %>"><%= flag_icon Locales::AVAILABLE[locale][:flag_id] %> <%= locale %></span> <%# this is all on one line for a reason. See http://stackoverflow.com/a/25879479 %>
<span class="label label-<%= class_panel %>"><%= locale %></span> <%# this is all on one line for a reason. See http://stackoverflow.com/a/25879479 %>

This comment has been minimized.

Copy link
@jonatanklosko

jonatanklosko Mar 8, 2020

Member

Pretty sure the SO link is no longer relevant here =)

@viroulep

This comment has been minimized.

Copy link
Member

viroulep commented Mar 9, 2020

I've not yet succeeded in getting the project running locally

Are you running into some specific issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.