Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Combined Rounds to Cutoff Rounds #5262

Open
wants to merge 6 commits into
base: master
from

Conversation

@Ivan-Brigidano
Copy link
Member

Ivan-Brigidano commented Mar 15, 2020

Fixes #5101
Probably needs several fixes.

@jonatanklosko

This comment has been minimized.

Copy link
Member

jonatanklosko commented Mar 17, 2020

This doesn't actually updated the round names:

"c":
name: "Combined Final"
cellName: "Combined Final"
"d":
name: "Combined First round"
cellName: "Combined First"
"e":
name: "Combined Second round"
cellName: "Combined Second"
"f":
name: "Final"
cellName: "Final"
"g":
name: "Combined Third round"
cellName: "Combined Third"
"h":
name: "Combined qualification"
cellName: "Combined qualification"

Perhaps you searched strictly for lowercase "combined"?

@Ivan-Brigidano

This comment has been minimized.

Copy link
Member Author

Ivan-Brigidano commented Mar 18, 2020

Perhaps you searched strictly for lowercase "combined"?

Not exactly. The problem was that I only searched combined round. Now I have also searched combined first, combined second, combined third and combined final.
Now the changes are visible on the localhost!

Copy link
Member

jonatanklosko left a comment

Top level question: is using cutoff the best idea? What about the alternative of just calling any final "Final" etc., similarly to WCA Live, would it make sense to bring that up and discuss with some teams?

('f', 99, 'Final', 'Final', 1),
('g', 70, 'Combined Third round', 'Combined Third', 0),
('g', 70, 'Cutoff Third round', 'Cutoff Third', 0),
('h', 10, 'Combined qualification', 'Combined qualification', 0);"
ActiveRecord::Base.connection.execute(sql)

This comment has been minimized.

Copy link
@jonatanklosko

jonatanklosko Mar 18, 2020

Member

In order for that to take effect you'd need to create a migration similar to this one.
(the Rails part of the website uses i18n phrases, so it doesn't really matter, some PHP code may still use these names though).

@Ivan-Brigidano

This comment has been minimized.

Copy link
Member Author

Ivan-Brigidano commented Mar 19, 2020

Top level question: is using cutoff the best idea? What about the alternative of just calling any final "Final" etc., similarly to WCA Live, would it make sense to bring that up and discuss with some teams?

In my opinion as a WRC member, I think it is worth it to use the official name in the website. This way the competitors can understand easily the schedule.
@lgarron what do you think?

@Ivan-Brigidano

This comment has been minimized.

Copy link
Member Author

Ivan-Brigidano commented Mar 19, 2020

@jonatanklosko I just added the migration but I need some help with that.
I wasn't able to run bin/rails db:migrate and got this error:

warning: parser/current is loading parser/ruby25, which recognizes
warning: 2.5.7-compliant syntax, but you are running 2.5.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
warning package.json: No license field                                         
warning No license field                                                       
== 20200319193625 RenameCombinedRoundsToCutoffRounds: migrating ===============
rails aborted!
StandardError: An error has occurred, all later migrations canceled:

uninitialized constant RenameCombinedRoundsToCutoffRounds::RoundTypes
/Users/ivanbrigidano/GitHub/worldcubeassociation.org/WcaOnRails/db/migrate/20200319193625_rename_combined_rounds_to_cutoff_rounds.rb:6:in `change'
(...)
@lgarron

This comment has been minimized.

Copy link
Member

lgarron commented Mar 19, 2020

In my opinion as a WRC member, I think it is worth it to use the official name in the website. This way the competitors can understand easily the schedule.
@lgarron what do you think?

I think it's fine not to emphasize "cutoff" in the round name — it generally only tells you something unexpected if there is a cutoff on a round that wasn't the first round.

So I'd advocate for taking out "cutoff" here, although I think it would be okay to keep. (Although in that case, what do you think of "First Round (with cutoff)"?

@Ivan-Brigidano

This comment has been minimized.

Copy link
Member Author

Ivan-Brigidano commented Mar 20, 2020

I think it's fine not to emphasize "cutoff" in the round name — it generally only tells you something unexpected if there is a cutoff on a round that wasn't the first round.

So I'd advocate for taking out "cutoff" here, although I think it would be okay to keep. (Although in that case, what do you think of "First Round (with cutoff)"?

Well the "cutoff" is arguably redundant. Do you mean removing it for every round or just for First Round? Also, would you maintain the full name on the database?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.