You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I already did the upgrade in a branch and it worked fine when running standalone shadow-cljs. It however broke when trying to run shadow-cljs embedded in lein which many users do.
I'm going to hold off until the lein upgrade is out or maybe try to figure out how to properly keep support for the older version and the new. Should be doable via some dynamic var lookups.
Yeah, that’s basically what I plan to do for piggieback. Not very pretty,
but gets the job done.
On Sat, 28 Jul 2018 at 23:13, Thomas Heller ***@***.***> wrote:
I already did the upgrade in a branch and it worked fine when running
standalone shadow-cljs. It however broke when trying to run shadow-cljs
embedded in lein which many users do.
I'm going to hold off until the lein upgrade is out or maybe try to figure
out how to properly keep support for the older version and the new. Should
be doable via some dynamic var lookups.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#348 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGVyvphCiMZm2fo3i1zbh-JyAtfRJ-Mks5uLMXvgaJpZM4VlJZ9>
.
Just a follow-up of https://github.com/nrepl/piggieback
I noticed that there are only a handful of references to tools.nrepl in the code, so updating this should be pretty easy.
The text was updated successfully, but these errors were encountered: