Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nREPL 0.4+ #348

Closed
bbatsov opened this issue Jul 28, 2018 · 2 comments
Closed

Add support for nREPL 0.4+ #348

bbatsov opened this issue Jul 28, 2018 · 2 comments

Comments

@bbatsov
Copy link

bbatsov commented Jul 28, 2018

Just a follow-up of https://github.com/nrepl/piggieback

I noticed that there are only a handful of references to tools.nrepl in the code, so updating this should be pretty easy.

@thheller
Copy link
Owner

I already did the upgrade in a branch and it worked fine when running standalone shadow-cljs. It however broke when trying to run shadow-cljs embedded in lein which many users do.

I'm going to hold off until the lein upgrade is out or maybe try to figure out how to properly keep support for the older version and the new. Should be doable via some dynamic var lookups.

@bbatsov
Copy link
Author

bbatsov commented Jul 28, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants