New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature request] enable build-report as part of the normal release process (instead of having to build the report and release separately) #881
Comments
In theory that is not a problem. The only option the build-report would need to force is |
👍 So would you be happy with a new option in the build section of shadow-cljs.edn which controls report generation such as :build-report true And instead of forcing source-map true how about a warning along the lines of "Unable to generate a build-report without source-maps" if the build config contains :build-report true but not :compiler-options {:source-map true}? |
I rewrote the build-report UI today, which was long overdue. There are a couple things I want to sort out before hooking up the report into the build directly. You could in theory hook it up yourself via a build hook in the |
In
in your build config which will generate a Optionally you can overwrite where this is written to via
The |
@thheller that's awesome. Thank you for such a rapid & responsive resolution. I really like the new UI in the report, and I can see myself doing something with the embedded data down the track too to track build size over time, etc :) |
That data was previously also generated as |
Ah right! Well I'm easy at the moment because I'm not using it for build
stats yet. Great if you can add it but no rush from my side
Thanks again
…On Tue, 11 May 2021, 5:01 pm Thomas Heller, ***@***.***> wrote:
That data was previously also generated as bundle-info.edn but the hook
doesn't generate that file at all. I can add an option if you are
interested in that data. It is the same data as in the HTML but would maybe
save an extraction step.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#881 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI7ROYOWNJWBG4ZPDWM4QLTNDI4XANCNFSM44MWSKPQ>
.
|
Firstly, thank you @thheller for shadow-cljs!
This is a feature request - currently we have our CI pipeline generate a build report at the same time as a release, so we run
Both takes a little while, so I guess I'm wondering if it would be useful to add an option to generate the report as part of the release build and avoid building the release twice?
I'd be happy to take a crack at a PR if that would be useful?
The text was updated successfully, but these errors were encountered: