feat(config): remove Prettier plugin

BREAKING CHANGE: Removed [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier), and its prettier/prettier rule from the config. Projects should have Prettier running without ESLint anyway so it also processes other file types. Running it within Prettier offers marginal improvements only, and has a performance drawback, as well as unnecessarily tying together formatting choices governed by Prettier and the ESLint config.

Author: thibaudcolas

package-lock.json

@@ -40,7 +40,6 @@
   "dependencies": {
     "eslint-plugin-import": "^2.14.0",
     "eslint-plugin-jsx-a11y": "^6.1.1",
-    "eslint-plugin-prettier": "^2.6.2",
     "eslint-plugin-react": "^7.11.1"
   },
   "peerDependencies": {

package.json

@@ -134,7 +134,6 @@ exports[`semver - should those tests break, consider releasing a new major versi
 Object {
   "eslint-plugin-import": "^2.14.0",
   "eslint-plugin-jsx-a11y": "^6.1.1",
-  "eslint-plugin-prettier": "^2.6.2",
   "eslint-plugin-react": "^7.11.1",
 }
 `;

src/__snapshots__/semver.test.js.snap

@@ -9,7 +9,6 @@ const path = require("path");
 const prettier = require("prettier");
 
 const { getComputedConfig, wrapInPlugin } = require("./config");
-const prettierConfig = require("../prettier.config");
 const base = require("./base");
 
 const configs = {
@@ -20,10 +19,6 @@ const configs = {
       "prettier/flowtype",
       "prettier/react",
     ]),
-    plugins: ["prettier"],
-    rules: Object.assign({}, base.rules, {
-      "prettier/prettier": ["error", prettierConfig],
-    }),
   },
 };
 

src/buildConfigs.js

@@ -38,7 +38,7 @@ describe("buildConfigs", () => {
     expect(
       cli.executeOnText("import test from 'potato'; var foo;", "foo.js"),
     ).toMatchObject({
-      errorCount: 5,
+      errorCount: 4,
     });
   });
 });

src/buildConfigs.test.js

@@ -1,13 +1,11 @@
 const importPlugin = require("eslint-plugin-import");
 const jsxA11YPlugin = require("eslint-plugin-jsx-a11y");
 const reactPlugin = require("eslint-plugin-react");
-const prettierPlugin = require("eslint-plugin-prettier");
 
 const plugins = {
   import: importPlugin,
   "jsx-a11y": jsxA11YPlugin,
   react: reactPlugin,
-  prettier: prettierPlugin,
 };
 
 /**