Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cron + percent notifications #28

Merged
merged 8 commits into from Mar 14, 2019

Conversation

Projects
None yet
2 participants
@JasonMillward
Copy link
Contributor

JasonMillward commented Mar 13, 2019

Gives the ability for a user to get regular notifications every X minutes.
#25 (comment)

@@ -152,6 +172,14 @@ def sent_m70(self, comm_instance, phase, cmd, cmd_type, gcode, *args, **kwargs):
:param kwargs:
:return:
"""
if gcode and gcode != "G1":

This comment has been minimized.

@JasonMillward

JasonMillward Mar 13, 2019

Author Contributor

This is so we don't calculate the time difference every G1 which is send multiple times a second.

@JasonMillward JasonMillward changed the title Cron notifications Cron + percent notifications Mar 13, 2019

@JasonMillward

This comment has been minimized.

Copy link
Contributor Author

JasonMillward commented Mar 13, 2019

Should handle #17 now too.

@thijsbekke

This comment has been minimized.

Copy link
Owner

thijsbekke commented Mar 13, 2019

Nice work! Unfortunately I can not merge this yet. There must be some kind of mechanism that this functionality does not use the default API key. Otherwise that API key will reach his limit very quick.

Very exited to merge this, and many people will enjoy it I guess. Maybe I can find some time tomorrow, too help.

@JasonMillward

This comment has been minimized.

Copy link
Contributor Author

JasonMillward commented Mar 14, 2019

Perhaps a notification to the front end too?

self._plugin_manager.send_plugin_message(self._identifier, dict(type="popup", msg="Please use your own API key for this functionality"))
@JasonMillward

This comment has been minimized.

Copy link
Contributor Author

JasonMillward commented Mar 14, 2019

image

Now the new functionality can't be used with the default API key.

@thijsbekke thijsbekke self-assigned this Mar 14, 2019

@thijsbekke thijsbekke merged commit 43f11e3 into thijsbekke:master Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.