Cron + percent notifications #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonMillward
commented
Mar 13, 2019
| @@ -152,6 +172,14 @@ def sent_m70(self, comm_instance, phase, cmd, cmd_type, gcode, *args, **kwargs): | |||
| :param kwargs: | |||
| :return: | |||
| """ | |||
| if gcode and gcode != "G1": | |||
There was a problem hiding this comment.
This is so we don't calculate the time difference every G1 which is send multiple times a second.
|
Should handle #17 now too. |
|
Nice work! Unfortunately I can not merge this yet. There must be some kind of mechanism that this functionality does not use the default API key. Otherwise that API key will reach his limit very quick. Very exited to merge this, and many people will enjoy it I guess. Maybe I can find some time tomorrow, too help. |
|
Perhaps a notification to the front end too? |
|
Now the new functionality can't be used with the default API key. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives the ability for a user to get regular notifications every X minutes.
#25 (comment)