Skip to content

Cron + percent notifications - #28

Merged
thijsbekke merged 8 commits into
thijsbekke:masterfrom
JasonMillward:feature/cron-notifications
Mar 14, 2019
Merged

thijsbekke merged 8 commits into
thijsbekke:masterfrom
JasonMillward:feature/cron-notifications

Conversation

@JasonMillward

Copy link
Copy Markdown
Contributor

Gives the ability for a user to get regular notifications every X minutes.
#25 (comment)

:param kwargs:
:return:
"""
if gcode and gcode != "G1":

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so we don't calculate the time difference every G1 which is send multiple times a second.

@JasonMillward JasonMillward changed the title Cron notifications Cron + percent notifications Mar 13, 2019
@JasonMillward

Copy link
Copy Markdown
Contributor Author

Should handle #17 now too.

@thijsbekke

Copy link
Copy Markdown
Owner

Nice work! Unfortunately I can not merge this yet. There must be some kind of mechanism that this functionality does not use the default API key. Otherwise that API key will reach his limit very quick.

Very exited to merge this, and many people will enjoy it I guess. Maybe I can find some time tomorrow, too help.

@JasonMillward

Copy link
Copy Markdown
Contributor Author

Perhaps a notification to the front end too?

self._plugin_manager.send_plugin_message(self._identifier, dict(type="popup", msg="Please use your own API key for this functionality"))

@JasonMillward

Copy link
Copy Markdown
Contributor Author

image

Now the new functionality can't be used with the default API key.

@thijsbekke thijsbekke self-assigned this Mar 14, 2019
@thijsbekke
thijsbekke merged commit 43f11e3 into thijsbekke:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants