Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4.4] rollback "tellFailure" logic change in TbAbstractGetAttributesNode #8009

Merged
merged 1 commit into from Jan 30, 2023

Conversation

ShvaykaD
Copy link
Contributor

@ShvaykaD ShvaykaD commented Jan 30, 2023

Pull Request description

Issue: #7998

General checklist

  • You have reviewed the guidelines document.
  • PR name contains fix version. For example, "[3.3.4] Hotfix of some UI component" or "[3.4] New Super Feature".
  • The milestone is specified and corresponds to fix version.
  • Description references specific issue.
  • Description contains human-readable scope of changes.
  • Description contains brief notes about what needs to be added to the documentation.
  • No merge conflicts, commented blocks of code, code formatting issues.
  • Changes are backward compatible or upgrade script is provided.
  • Similar PR is opened for PE version to simplify merge. Required for internal contributors only.

Front-End feature checklist

  • Screenshots with affected component(s) are added. The best option is to provide 2 screens: before and after changes;
  • If you change the widget or other API, ensure it is backward-compatible or upgrade script is present.
  • Ensure new API is documented here

Back-End feature checklist

  • Added corresponding unit and/or integration test(s). Provide written explanation in the PR description if you have failed to add tests.
  • If new dependency was added: the dependency tree is checked for conflicts.
  • If new service was added: the service is marked with corresponding @TbCoreComponent, @TbRuleEngineComponent, @TbTransportComponent, etc.
  • If new REST API was added: the RestClient.java was updated, issue for Python REST client is created.

@ShvaykaD ShvaykaD added the bug label Jan 30, 2023
@ShvaykaD ShvaykaD added this to the 3.4.4 milestone Jan 30, 2023
@ashvayka ashvayka added the Rule Engine Changes to Rule Engine label Jan 30, 2023
@ashvayka ashvayka merged commit 9ff4a1d into thingsboard:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Rule Engine Changes to Rule Engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants