Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring time window component #8062

Merged

Conversation

ArtemDzhereleiko
Copy link
Contributor

@ArtemDzhereleiko ArtemDzhereleiko commented Feb 8, 2023

Pull Request description

Refactoring Timewindow
image

General checklist

  • You have reviewed the guidelines document.
  • PR name contains fix version. For example, "[3.3.4] Hotfix of some UI component" or "[3.4] New Super Feature".
  • The milestone is specified and corresponds to fix version.
  • Description references specific issue.
  • Description contains human-readable scope of changes.
  • Description contains brief notes about what needs to be added to the documentation.
  • No merge conflicts, commented blocks of code, code formatting issues.
  • Changes are backward compatible or upgrade script is provided.
  • Similar PR is opened for PE version to simplify merge. Required for internal contributors only.

Front-End feature checklist

  • Screenshots with affected component(s) are added. The best option is to provide 2 screens: before and after changes;
  • If you change the widget or other API, ensure it is backward-compatible or upgrade script is present.
  • Ensure new API is documented here

@vvlladd28 vvlladd28 added this to the 3.5 milestone Feb 8, 2023
@vvlladd28 vvlladd28 added bug UI UI changes labels Feb 8, 2023
})
realtime: this.fb.group({
realtimeType: [{
value: this.defined(realtime, realtime.realtimeType) ? this.timewindow.realtime.realtimeType : RealtimeWindowType.LAST_INTERVAL,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be better to replace it with a function from the product code - isDefined. Example: IsDefined(realtime?.realtimeType)

@ikulikov ikulikov merged commit 5d54716 into thingsboard:develop/3.5 Mar 24, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug UI UI changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants