Elmer Thomas
thinkingserious

Organizations

@sendgrid
Jul 27, 2016
thinkingserious commented on pull request sendgrid/sendgrid-nodejs#261
@thinkingserious

This is awesome! Can you please allow us to send you some swag? Just email dx@sendgrid.com with a mailing address and T-shirt size.

Jul 27, 2016
@thinkingserious

Thanks for the ping @ikatkov, I see that three others have upvoted this issue, so I've updated our internal queue to help push this issue higher in…

Jul 27, 2016
thinkingserious commented on pull request sendgrid/sendgrid-nodejs#261
@thinkingserious

To test locally: Install Prism: https://stoplight.io/prism Run ./prism run --mock --list --spec https://raw.githubusercontent.com/sendgrid/sendgr…

Jul 27, 2016
@thinkingserious

@adambuczynski you can keep in the same PR, thanks!

Jul 26, 2016
thinkingserious commented on pull request sendgrid/sendgrid-nodejs#261
@thinkingserious

Ah, since you are not part of the SendGrid repo, Travis is not loading the MOCK_HOST variable. I'll send instructions on how to create the test env…

Jul 26, 2016
@thinkingserious

Agreed. I like this option: "Check if promises are supported or not, throw an error if they aren't but if people try to use them", but also allowin…

Jul 26, 2016
@thinkingserious

We need to support Node.js versions: "0.10", "0.12", "iojs", "4" I'm fine with the more modern approach if we don't break support for those versions.

Jul 26, 2016
@thinkingserious

@adambuczynski, I'm happy to use yours, it looks solid :) Please add it as part of your commit.

Jul 26, 2016
@thinkingserious

@adambuczynski, We use this linter: http://eslint.org along with the standard style guide. Which one do you use? If we can sync up and use the same…

Jul 26, 2016
@thinkingserious
Fixed link to SendGrid tutorial.
1 commit with 1 addition and 1 deletion
Jul 26, 2016
@thinkingserious
  • @thinkingserious 435d525
    Fixed link to SendGrid tutorial.
Jul 26, 2016
@thinkingserious
  • @thinkingserious a37280e
    Fixed permissions on prism.sh script
Jul 26, 2016
@thinkingserious
  • @thinkingserious 3da7e5f
    Fixing path to prism install script
Jul 26, 2016
@thinkingserious
  • @thinkingserious 970be72
    Adding prism script to the repo
Jul 26, 2016
@thinkingserious
  • @thinkingserious 1a97aeb
    Add prism directory via Travis
Jul 26, 2016
@thinkingserious
Jul 26, 2016
Jul 26, 2016
@thinkingserious
  • @thinkingserious 8463cb6
    Version Bump v3.0.6: Added troubleshooting section
Jul 26, 2016
Jul 26, 2016
@thinkingserious
  • @thinkingserious e5471ae
    Version Bump v3.0.6: Added troubleshooting section
Jul 26, 2016
Jul 26, 2016
@thinkingserious
  • @thinkingserious 980c021
    Version Bump v3.0.11: Added troubleshooting section
Jul 26, 2016
@thinkingserious
Jul 26, 2016
@thinkingserious
Added troubleshooting section
1 commit with 132 additions and 0 deletions
Jul 26, 2016
@thinkingserious

@34code, Do you mind sending us (dx@sendgrid.com) before and after screenshots so I can file the bug report?

Jul 26, 2016
@thinkingserious
Added troubleshooting section
1 commit with 132 additions and 0 deletions