Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

status should be used when we create the entry #12

Merged
merged 1 commit into from

2 participants

@tleunen

There is an error when we create the entry and we push it into the array of entries.. We set the resource and the state, but the state is never used in the code. It should be "status".

@tleunen tleunen entry.status instead of entry.state
entry.status should be used instead of entry.state when we push the
resource into the array of entries, because entry.state is never used in
the whole code. It's entry.status.
b2811c3
@tleunen tleunen closed this
@tleunen tleunen reopened this
@joelfillmore joelfillmore merged commit 97a63c4 into thinkpixellab:master
@joelfillmore

@tleunen - thanks for catching and fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 14, 2012
  1. @tleunen

    entry.status instead of entry.state

    tleunen authored
    entry.status should be used instead of entry.state when we push the
    resource into the array of entries, because entry.state is never used in
    the whole code. It's entry.status.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  PxLoader.js
View
2  PxLoader.js
@@ -65,7 +65,7 @@ function PxLoader(settings) {
entries.push({
resource: resource,
- state: ResourceState.QUEUED
+ status: ResourceState.QUEUED
});
};
Something went wrong with that request. Please try again.