Skip to content

Sorting Visualizer #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 9, 2023
Merged

Sorting Visualizer #754

merged 5 commits into from
Oct 9, 2023

Conversation

@Abhineshhh
Copy link
Contributor

@Abhineshhh Abhineshhh commented Oct 8, 2023 •
edited
Loading

Developer Checklist

  • Followed guidelines mentioned in the readme file.
  • Followed directory structure. (e.g. ProjectName/{USERNAME}/...yourfiles)
  • Starred ⭐ the Repo (Optional)

Summary

Added a sorting visualizer project

Screenshot

Screenshot 2023-10-09 003802

@Abhineshhh
Copy link
Contributor Author

Abhineshhh commented Oct 8, 2023

if u liked it then add hacktoberfest label @PBJI

@ayan-joshi
Copy link
Contributor

ayan-joshi commented Oct 8, 2023

if u liked it then add hacktoberfest label @PBJI

I have a request , please create an issue and work on that , sorting visualizer was the issue created by me I was also working on the same @AbhineshJha

@Abhineshhh
Copy link
Contributor Author

Abhineshhh commented Oct 8, 2023 •
edited
Loading

read README.md @ayan-joshi
there is no mention of creating an issue firstly

@PBJI
Copy link
Collaborator

PBJI commented Oct 9, 2023

@AbhineshJha correct, it's just by convention that people create Issues, so that other get's inspired and work on same projects.

@PBJI
Copy link
Collaborator

PBJI commented Oct 9, 2023

@AbhineshJha Use pascal case to name your project directory.

sorting-visualizer ---> SortingVisualizer

@PBJI PBJI added the changeRequested The requested changes should be adhered to before further review or approval. label Oct 9, 2023
@PBJI PBJI self-requested a review October 9, 2023 05:14
PBJI
PBJI requested changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@PBJI PBJI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename project directory to SortingVisualizer

thank you

@Abhineshhh
Copy link
Contributor Author

Abhineshhh commented Oct 9, 2023

Done @PBJI

@PBJI
Copy link
Collaborator

PBJI commented Oct 9, 2023

Done @PBJI

Remove the space in Sorting Visualizer folder name

@Abhineshhh
Copy link
Contributor Author

Abhineshhh commented Oct 9, 2023

doneeeee @PBJI

@Abhineshhh
Copy link
Contributor Author

Abhineshhh commented Oct 9, 2023

hey @PBJI can u merge this pr ?

@PBJI PBJI merged commit 0e82858 into thinkswell:master Oct 9, 2023
@Abhineshhh Abhineshhh deleted the sortingvisualizer branch October 9, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PBJI PBJI PBJI approved these changes

Assignees

No one assigned

Labels

changeRequested The requested changes should be adhered to before further review or approval.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Abhineshhh @ayan-joshi @PBJI