New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a caller of #finalized! #87

Merged
merged 1 commit into from Sep 30, 2017

Conversation

Projects
None yet
3 participants
@meganemura
Contributor

meganemura commented Sep 21, 2017

#finalized! is a method of Thinreports::Core::Shape::List::PageState.

Sorry for lack of reproducing test.

@hidakatsuya

This comment has been minimized.

Show comment
Hide comment
@hidakatsuya

hidakatsuya Sep 25, 2017

Member

Thanks. OK, I'll confirm the issue.

Member

hidakatsuya commented Sep 25, 2017

Thanks. OK, I'll confirm the issue.

@Cesco869

This comment has been minimized.

Show comment
Hide comment
@Cesco869

Cesco869 Sep 25, 2017

Cesco869 commented Sep 25, 2017

@hidakatsuya hidakatsuya merged commit 4e94976 into thinreports:master Sep 30, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@hidakatsuya

This comment has been minimized.

Show comment
Hide comment
@hidakatsuya

hidakatsuya Sep 30, 2017

Member

Thank you for your contribution. I have merged with test in b6eda54 and a6f9d90.

Member

hidakatsuya commented Sep 30, 2017

Thank you for your contribution. I have merged with test in b6eda54 and a6f9d90.

@meganemura meganemura deleted the meganemura:internal-method branch Sep 30, 2017

@hidakatsuya

This comment has been minimized.

Show comment
Hide comment
@hidakatsuya

hidakatsuya Sep 30, 2017

Member

Code to reproduce the issue:

foo.tlf has two list. The one has page-break option disabled, and other one has page-break option enabled.

report = Thinreports::Report.new layout: 'foo.tlf'

# list#foo: auto-page-break disabled
report.list(:foo).add_row

# list#bar: auto-page-break enabled
5.times { report.list(:bar).add_row } #=> `NoMethodError: undefined method `finalized!'`
Member

hidakatsuya commented Sep 30, 2017

Code to reproduce the issue:

foo.tlf has two list. The one has page-break option disabled, and other one has page-break option enabled.

report = Thinreports::Report.new layout: 'foo.tlf'

# list#foo: auto-page-break disabled
report.list(:foo).add_row

# list#bar: auto-page-break enabled
5.times { report.list(:bar).add_row } #=> `NoMethodError: undefined method `finalized!'`
@hidakatsuya

This comment has been minimized.

Show comment
Hide comment
@hidakatsuya
Member

hidakatsuya commented Sep 30, 2017

@meganemura

This comment has been minimized.

Show comment
Hide comment
@meganemura

meganemura Oct 1, 2017

Contributor

Thanks 🎉

Contributor

meganemura commented Oct 1, 2017

Thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment