Skip to content
This repository was archived by the owner on Jun 19, 2024. It is now read-only.

[Dashboard] feat: added button to view deployed contract on block explorer - #1217

Merged
jnsdls merged 6 commits into
thirdweb-dev:mainfrom
ThianHooi:thianhooi/feat/button-to-view-contract-on-block-explorer
Jun 8, 2023
Merged

[Dashboard] feat: added button to view deployed contract on block explorer#1217
jnsdls merged 6 commits into
thirdweb-dev:mainfrom
ThianHooi:thianhooi/feat/button-to-view-contract-on-block-explorer

Conversation

@ThianHooi

Copy link
Copy Markdown
Contributor
  • feat: added a button on the deployed contract page which opens a new tab to view the deployed contract on the block explorer

The outcome is as such:

  • Notice the icon beside the contract address
    image

@vercel

vercel Bot commented May 17, 2023

Copy link
Copy Markdown

@ThianHooi is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@vercel

vercel Bot commented May 17, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2023 5:56am

@jnsdls

jnsdls commented May 17, 2023

Copy link
Copy Markdown
Contributor

hey @ThianHooi thanks for this contribution!

Out of interest what functionality is missing from the dashboard itself that you would need to go to a blockexplorer for in the first place?

While this seems useful at first glance ultimately we'd want to cover any such functionality (or at least most of it) directly within the dashboard. :)

Comment thread components/contract-components/tables/deployed-contracts.tsx Outdated
@ThianHooi

Copy link
Copy Markdown
Contributor Author

hey @ThianHooi thanks for this contribution!

Out of interest what functionality is missing from the dashboard itself that you would need to go to a blockexplorer for in the first place?

While this seems useful at first glance ultimately we'd want to cover any such functionality (or at least most of it) directly within the dashboard. :)

@jnsdls thirdweb dashboard does cover a lot of functionality, especially for prebuilt contracts. However, functionalities such as viewing list of transactions, viewing balance of tokens of a contract, and viewing the analytics, can be done only on block explorer

@jnsdls

jnsdls commented May 22, 2023

Copy link
Copy Markdown
Contributor

hey @ThianHooi thanks for this contribution!
Out of interest what functionality is missing from the dashboard itself that you would need to go to a blockexplorer for in the first place?
While this seems useful at first glance ultimately we'd want to cover any such functionality (or at least most of it) directly within the dashboard. :)

@jnsdls thirdweb dashboard does cover a lot of functionality, especially for prebuilt contracts. However, functionalities such as viewing list of transactions, viewing balance of tokens of a contract, and viewing the analytics, can be done only on block explorer

thx this is a good list of things for us to add to the dashboard capabilities (we're already working on some of the underlying requirements of these)

In the meantime I'm happy to add something like your PR. Instead of adding it into the table could you add it to the contract overview page itself (I think that would be a better place for it, you also get some more space to maybe add the name of the explorer into the link?)

@ThianHooi
ThianHooi requested a review from jnsdls May 24, 2023 14:47
@ThianHooi

Copy link
Copy Markdown
Contributor Author
  • feat: added a button on the contract page which opens a new tab to view the deployed contract on the block explorer

Outcome as such:

image

@jnsdls
jnsdls added this pull request to the merge queue Jun 8, 2023
Merged via the queue into thirdweb-dev:main with commit cf9ee7a Jun 8, 2023
@ThianHooi

Copy link
Copy Markdown
Contributor Author

@jnsdls Thanks for merging the PR.

I actually have been trying to reach out to you on Twitter. I really hope you would spend some time to go through your message request and read my DM. (So sorry to reach out to you using this way on Github)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants