From 40e2c5e4e0e13716559eb3caf7ad81304307a953 Mon Sep 17 00:00:00 2001
From: iuwqyir <toomas.oosalu@gmail.com>
Date: Tue, 29 Jul 2025 14:41:03 +0300
Subject: [PATCH] remove validate query checks

---
 internal/common/utils.go       | 65 ----------------------------------
 internal/storage/clickhouse.go |  6 ----
 2 files changed, 71 deletions(-)

diff --git a/internal/common/utils.go b/internal/common/utils.go
index 81f70f6..221386a 100644
--- a/internal/common/utils.go
+++ b/internal/common/utils.go
@@ -1,10 +1,7 @@
 package common
 
 import (
-	"fmt"
 	"math/big"
-	"regexp"
-	"strings"
 )
 
 func SliceToChunks[T any](values []T, chunkSize int) [][]T {
@@ -22,68 +19,6 @@ func SliceToChunks[T any](values []T, chunkSize int) [][]T {
 	return chunks
 }
 
-var allowedFunctions = map[string]struct{}{
-	"sum":                  {},
-	"count":                {},
-	"countdistinct":        {},
-	"avg":                  {},
-	"max":                  {},
-	"min":                  {},
-	"reinterpretasuint256": {},
-	"reverse":              {},
-	"unhex":                {},
-	"substring":            {},
-	"length":               {},
-	"touint256":            {},
-	"if":                   {},
-	"tostartofmonth":       {},
-	"tostartofday":         {},
-	"tostartofhour":        {},
-	"tostartofminute":      {},
-	"todate":               {},
-	"todatetime":           {},
-	"concat":               {},
-	"in":                   {},
-	"and":                  {},
-	"or":                   {},
-}
-
-var disallowedPatterns = []string{
-	`(?i)\b(INSERT|DELETE|UPDATE|DROP|CREATE|ALTER|TRUNCATE|EXEC|;|--)`,
-}
-
-// ValidateQuery checks the query for disallowed patterns and ensures only allowed functions are used.
-func ValidateQuery(query string) error {
-	// Check for disallowed patterns
-	for _, pattern := range disallowedPatterns {
-		matched, err := regexp.MatchString(pattern, query)
-		if err != nil {
-			return fmt.Errorf("error checking disallowed patterns: %v", err)
-		}
-		if matched {
-			return fmt.Errorf("query contains disallowed keywords or patterns")
-		}
-	}
-
-	// Ensure the query is a SELECT statement
-	trimmedQuery := strings.TrimSpace(strings.ToUpper(query))
-	if !strings.HasPrefix(trimmedQuery, "SELECT") {
-		return fmt.Errorf("only SELECT queries are allowed")
-	}
-
-	// Extract function names and validate them
-	functionPattern := regexp.MustCompile(`(?i)(\b\w+\b)\s*\(`)
-	matches := functionPattern.FindAllStringSubmatch(query, -1)
-	for _, match := range matches {
-		funcName := match[1]
-		if _, ok := allowedFunctions[strings.ToLower(funcName)]; !ok {
-			return fmt.Errorf("function '%s' is not allowed", funcName)
-		}
-	}
-
-	return nil
-}
-
 func ConvertBigNumbersToString(data interface{}) interface{} {
 	switch v := data.(type) {
 	case map[string]interface{}:
diff --git a/internal/storage/clickhouse.go b/internal/storage/clickhouse.go
index d914ced..653090f 100644
--- a/internal/storage/clickhouse.go
+++ b/internal/storage/clickhouse.go
@@ -473,9 +473,6 @@ func (c *ClickHouseConnector) GetAggregations(table string, qf QueryFilter) (Que
 	// Use the new query building logic
 	query := c.buildQuery(table, selectColumns, qf)
 
-	if err := common.ValidateQuery(query); err != nil {
-		return QueryResult[interface{}]{}, err
-	}
 	// Execute the query
 	rows, err := c.conn.Query(context.Background(), query)
 	if err != nil {
@@ -528,9 +525,6 @@ func (c *ClickHouseConnector) GetAggregations(table string, qf QueryFilter) (Que
 func executeQuery[T any](c *ClickHouseConnector, table, columns string, qf QueryFilter, scanFunc func(driver.Rows) (T, error)) (QueryResult[T], error) {
 	query := c.buildQuery(table, columns, qf)
 
-	if err := common.ValidateQuery(query); err != nil {
-		return QueryResult[T]{}, err
-	}
 	rows, err := c.conn.Query(context.Background(), query)
 	if err != nil {
 		return QueryResult[T]{}, err