From 7304c5b0c7060080f302160dc9b24b2becc17524 Mon Sep 17 00:00:00 2001 From: joaquim-verges <3353417+joaquim-verges@users.noreply.github.com> Date: Mon, 17 Jun 2024 21:46:10 +0000 Subject: [PATCH] refactor: respect Coinbase wallet optons when preloading (#3364) --- .changeset/giant-phones-mix.md | 5 +++++ .../src/react/web/utils/usePreloadWalletProviders.ts | 5 ++++- 2 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 .changeset/giant-phones-mix.md diff --git a/.changeset/giant-phones-mix.md b/.changeset/giant-phones-mix.md new file mode 100644 index 0000000000..d33d5c2338 --- /dev/null +++ b/.changeset/giant-phones-mix.md @@ -0,0 +1,5 @@ +--- +"thirdweb": patch +--- + +Respect coinbase wallet create settings when preloading the provider diff --git a/packages/thirdweb/src/react/web/utils/usePreloadWalletProviders.ts b/packages/thirdweb/src/react/web/utils/usePreloadWalletProviders.ts index 196ee47e43..9b9147d77e 100644 --- a/packages/thirdweb/src/react/web/utils/usePreloadWalletProviders.ts +++ b/packages/thirdweb/src/react/web/utils/usePreloadWalletProviders.ts @@ -2,6 +2,7 @@ import { useQueries } from "@tanstack/react-query"; import type { ThirdwebClient } from "../../../client/client.js"; import { COINBASE } from "../../../wallets/constants.js"; import type { Wallet } from "../../../wallets/interfaces/wallet.js"; +import type { CreateWalletArgs } from "../../../wallets/wallet-types.js"; export function usePreloadWalletProviders({ client, @@ -18,7 +19,9 @@ export function usePreloadWalletProviders({ const { getCoinbaseWebProvider } = await import( "../../../wallets/coinbase/coinbaseWebSDK.js" ); - await getCoinbaseWebProvider(); + await getCoinbaseWebProvider( + w.getConfig() as CreateWalletArgs[1], + ); // return _something_ return true; }