From d6e7e8df54e9488bc03bcff9c4878e6396a959ae Mon Sep 17 00:00:00 2001 From: Joaquim Verges Date: Tue, 20 Sep 2022 14:26:48 -0700 Subject: [PATCH 1/2] [SDK] Allow forcing direct deploys to deploy implementations from release flow --- packages/sdk/src/core/classes/contract-deployer.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/sdk/src/core/classes/contract-deployer.ts b/packages/sdk/src/core/classes/contract-deployer.ts index d348c9f7522..eb74b8d0855 100644 --- a/packages/sdk/src/core/classes/contract-deployer.ts +++ b/packages/sdk/src/core/classes/contract-deployer.ts @@ -502,10 +502,14 @@ export class ContractDeployer extends RPCConnectionHandler { * @internal * @param publishMetadataUri * @param constructorParamValues + * @param options */ public async deployContractFromUri( publishMetadataUri: string, constructorParamValues: any[], + options?: { + forceDirectDeploy?: boolean; + }, ) { const signer = this.getSigner(); invariant(signer, "A signer is required"); @@ -527,8 +531,8 @@ export class ContractDeployer extends RPCConnectionHandler { } catch (e) { // not a factory deployment, ignore } - - if (isDeployableViaFactory && factoryDeploymentData) { + const forceDirectDeploy = options?.forceDirectDeploy || false; + if (isDeployableViaFactory && factoryDeploymentData && !forceDirectDeploy) { const chainId = (await this.getProvider().getNetwork()).chainId; invariant( factoryDeploymentData.factoryAddresses, From 81596f682e7fd4cbfbad8fb6958d475ad48e244b Mon Sep 17 00:00:00 2001 From: Joaquim Verges Date: Tue, 20 Sep 2022 14:38:13 -0700 Subject: [PATCH 2/2] add changeset --- .changeset/weak-meals-lay.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/weak-meals-lay.md diff --git a/.changeset/weak-meals-lay.md b/.changeset/weak-meals-lay.md new file mode 100644 index 00000000000..9d068558153 --- /dev/null +++ b/.changeset/weak-meals-lay.md @@ -0,0 +1,5 @@ +--- +"@thirdweb-dev/sdk": patch +--- + +Allow forcing direct deploys to deploy implementations from release flow