Fix onConnect called twice with inApp social login in ConnectButton

[MananTank]

PR-Codex overview

This PR fixes the issue of onConnect prop being called twice when connecting inApp wallet using Social login.

Detailed summary

• Removed unnecessary done prop and function call
• Updated comments for clarity regarding when done function is called

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[linear]

CNCT-1218 ConnectButton onConnect callback triggered twice

[changeset-bot]

🦋 Changeset detected

Latest commit: 528e764

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
thirdweb	Patch
@thirdweb-dev/sdk	Patch
@thirdweb-dev/cli	Patch
@thirdweb-dev/react-core	Patch
@thirdweb-dev/react	Patch
@thirdweb-dev/unity-js-bridge	Patch
@thirdweb-dev/wallets	Patch
@thirdweb-dev/auth	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codspeed-hq]

CodSpeed Performance Report

Merging #3085 will not alter performance

_{Comparing cnct-1218 (528e764) with main (7955755)}

Summary

✅ 9 untouched benchmarks

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	39.24 KB (0%)	785 ms (0%)	3.1 s (+4.57% 🔺)	3.9 s
thirdweb (cjs)	88.65 KB (0%)	1.8 s (0%)	7.3 s (+3.24% 🔺)	9.1 s
thirdweb (minimal + tree-shaking)	4.75 KB (0%)	96 ms (0%)	164 ms (-51.76% 🔽)	259 ms
thirdweb/chains (tree-shaking)	423 B (0%)	10 ms (0%)	65 ms (-18.72% 🔽)	75 ms
thirdweb/react (minimal + tree-shaking)	23.11 KB (0%)	463 ms (0%)	387 ms (-43.28% 🔽)	849 ms

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.08%. Comparing base (7955755) to head (528e764).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3085   +/-   ##
=======================================
  Coverage   62.08%   62.08%           
=======================================
  Files         806      806           
  Lines       60293    60293           
  Branches     3220     3220           
=======================================
  Hits        37430    37430           
  Misses      22194    22194           
  Partials      669      669           

Flag	Coverage Δ		*Carryforward flag
legacy_packages	65.61% <ø> (ø)		Carriedforward from 431ddab
packages	61.29% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.