From 269fbe5ecf161289a4759e0c5f7b7fb7f99660e2 Mon Sep 17 00:00:00 2001
From: MananTank <manantankm@gmail.com>
Date: Thu, 13 Mar 2025 22:48:40 +0000
Subject: [PATCH] [TOOL-3691] Dashbaord: Keep project settings submit button
 always enabled (#6467)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on simplifying the logic for determining if form fields are "dirty" before enabling the save button in the `ProjectGeneralSettingsPage`. It removes checks for dirty states, allowing the save button to be enabled regardless of whether the fields have been modified.

### Detailed summary
- Removed `isNameDirty` check for the `name` field in `ProjectNameSetting`.
- Removed `isDomainsDirty` check for the `domains` field in `AllowedDomainsSetting`.
- Removed `isBundleIdsDirty` check for the `bundleIds` field in `AllowedBundleIDsSetting`.
- Updated save button to always have `disabled: false` for all settings.
- Kept `isPending` functionality unchanged based on `props.isUpdatingProject`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
---
 .../settings/ProjectGeneralSettingsPage.tsx   | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/apps/dashboard/src/app/team/[team_slug]/[project_slug]/settings/ProjectGeneralSettingsPage.tsx b/apps/dashboard/src/app/team/[team_slug]/[project_slug]/settings/ProjectGeneralSettingsPage.tsx
index 542e3012692..df746ae06c2 100644
--- a/apps/dashboard/src/app/team/[team_slug]/[project_slug]/settings/ProjectGeneralSettingsPage.tsx
+++ b/apps/dashboard/src/app/team/[team_slug]/[project_slug]/settings/ProjectGeneralSettingsPage.tsx
@@ -406,7 +406,6 @@ function ProjectNameSetting(props: {
   handleSubmit: () => void;
 }) {
   const { form, handleSubmit } = props;
-  const isNameDirty = form.getFieldState("name").isDirty;
 
   return (
     <SettingsCard
@@ -419,8 +418,8 @@ function ProjectNameSetting(props: {
       errorText={form.getFieldState("name").error?.message}
       saveButton={{
         onClick: handleSubmit,
-        disabled: !isNameDirty,
-        isPending: props.isUpdatingProject && isNameDirty,
+        disabled: false,
+        isPending: props.isUpdatingProject,
       }}
       bottomText="Please use 64 characters at maximum"
     >
@@ -501,7 +500,6 @@ function AllowedDomainsSetting(props: {
   handleSubmit: () => void;
 }) {
   const { form, handleSubmit } = props;
-  const isDomainsDirty = form.getFieldState("domains").isDirty;
 
   const helperText = (
     <ul className="flex list-disc flex-col gap-1.5 py-1 pl-3 text-muted-foreground text-sm [&>li]:pl-1">
@@ -544,8 +542,8 @@ function AllowedDomainsSetting(props: {
       errorText={form.getFieldState("domains", form.formState).error?.message}
       saveButton={{
         onClick: handleSubmit,
-        disabled: !isDomainsDirty,
-        isPending: props.isUpdatingProject && isDomainsDirty,
+        disabled: false,
+        isPending: props.isUpdatingProject,
       }}
       bottomText="This is only applicable for web applications"
     >
@@ -606,13 +604,12 @@ function AllowedBundleIDsSetting(props: {
   handleSubmit: () => void;
 }) {
   const { form, handleSubmit } = props;
-  const isBundleIdsDirty = form.getFieldState("bundleIds").isDirty;
   return (
     <SettingsCard
       saveButton={{
         onClick: handleSubmit,
-        disabled: !isBundleIdsDirty,
-        isPending: props.isUpdatingProject && isBundleIdsDirty,
+        disabled: false,
+        isPending: props.isUpdatingProject,
       }}
       noPermissionText={undefined}
       header={{
@@ -715,7 +712,7 @@ function EnabledServicesSetting(props: {
       errorText={undefined}
       saveButton={{
         onClick: handleSubmit,
-        disabled: !form.formState.isDirty,
+        disabled: false,
         isPending: props.isUpdatingProject,
       }}
       bottomText=""
@@ -1219,8 +1216,6 @@ function TransferProject(props: {
     selectedTeamId === props.currentTeamId ||
     !props.isOwnerAccount;
 
-  console.log({ selectedTeam: selectedTeamWithRole, isDisabled });
-
   const handleTransfer = () => {
     if (!hasOwnerRole) {
       return;