From c2ab5c15ed32362cb634525b9468afa1714be52e Mon Sep 17 00:00:00 2001 From: Yash Date: Sat, 29 Mar 2025 16:44:09 +0530 Subject: [PATCH 1/2] use default params --- .../src/extensions/prebuilts/deploy-published.ts | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/thirdweb/src/extensions/prebuilts/deploy-published.ts b/packages/thirdweb/src/extensions/prebuilts/deploy-published.ts index df29f6d26fb..e30c383b3bf 100644 --- a/packages/thirdweb/src/extensions/prebuilts/deploy-published.ts +++ b/packages/thirdweb/src/extensions/prebuilts/deploy-published.ts @@ -110,9 +110,14 @@ export async function deployPublishedContract( chain, deployMetadata, client, - initializeParams: contractParams || deployMetadata.constructorParams, - implementationConstructorParams: - implementationConstructorParams || deployMetadata.implConstructorParams, + initializeParams: { + ...deployMetadata.constructorParams, + ...contractParams, + }, + implementationConstructorParams: { + ...deployMetadata.implConstructorParams, + ...implementationConstructorParams, + }, salt, }); } From c50cede7a9c95c82b2d6dba5a2de3caa05edaf1c Mon Sep 17 00:00:00 2001 From: Yash Date: Sat, 29 Mar 2025 17:58:58 +0530 Subject: [PATCH 2/2] fix impl param merge --- .../thirdweb/src/extensions/prebuilts/deploy-published.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/thirdweb/src/extensions/prebuilts/deploy-published.ts b/packages/thirdweb/src/extensions/prebuilts/deploy-published.ts index e30c383b3bf..9151c9bed2d 100644 --- a/packages/thirdweb/src/extensions/prebuilts/deploy-published.ts +++ b/packages/thirdweb/src/extensions/prebuilts/deploy-published.ts @@ -240,14 +240,15 @@ export async function deployContractfromDeployMetadata( client, account, contractId: deployMetadata.name, - constructorParams: - processedImplParams || - (await getAllDefaultConstructorParamsForImplementation({ + constructorParams: { + ...(await getAllDefaultConstructorParamsForImplementation({ chain, client, contractId: deployMetadata.name, defaultExtensions: deployMetadata.defaultExtensions, })), + ...processedImplParams, + }, publisher: deployMetadata.publisher, version: deployMetadata.version, });