From 0dcde077f5cf9b514b66c6768e26f42be9f904b4 Mon Sep 17 00:00:00 2001
From: kumaryash90 <kumaryashcse@gmail.com>
Date: Mon, 31 Mar 2025 18:30:28 +0000
Subject: [PATCH] [SDK] Fix bytecode caching (#6593)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the bytecode caching mechanism in the `thirdweb` package by including additional metadata in the cache key, which improves cache differentiation and management.

### Detailed summary
- Updated the `cacheKey` in `deploy-metadata.ts` to include `compilerMetadata.publisher` and `compilerMetadata.version` along with `compilerMetadata.name` and `chain.id`.
- Removed the `version` and `publisher` fields from the deployment test case in `process-ref-deployments.test.ts`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
---
 .changeset/neat-wasps-count.md                               | 5 +++++
 .../src/extensions/prebuilts/process-ref-deployments.test.ts | 2 --
 packages/thirdweb/src/utils/any-evm/deploy-metadata.ts       | 2 +-
 3 files changed, 6 insertions(+), 3 deletions(-)
 create mode 100644 .changeset/neat-wasps-count.md

diff --git a/.changeset/neat-wasps-count.md b/.changeset/neat-wasps-count.md
new file mode 100644
index 00000000000..835b3b1caed
--- /dev/null
+++ b/.changeset/neat-wasps-count.md
@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+Fix bytecode caching
diff --git a/packages/thirdweb/src/extensions/prebuilts/process-ref-deployments.test.ts b/packages/thirdweb/src/extensions/prebuilts/process-ref-deployments.test.ts
index 11ab7c72c34..e8a592d4995 100644
--- a/packages/thirdweb/src/extensions/prebuilts/process-ref-deployments.test.ts
+++ b/packages/thirdweb/src/extensions/prebuilts/process-ref-deployments.test.ts
@@ -74,9 +74,7 @@ describe.runIf(process.env.TW_SECRET_KEY)(
         chain: ANVIL_CHAIN,
         account: TEST_ACCOUNT_A,
         contractId: "WETH9",
-        version: "0.0.1",
         salt: "",
-        publisher: "0x6453a486d52e0EB6E79Ec4491038E2522a926936",
       });
       forwarderAddress = await deployPublishedContract({
         client: TEST_CLIENT,
diff --git a/packages/thirdweb/src/utils/any-evm/deploy-metadata.ts b/packages/thirdweb/src/utils/any-evm/deploy-metadata.ts
index d956cae6154..1ca04a82416 100644
--- a/packages/thirdweb/src/utils/any-evm/deploy-metadata.ts
+++ b/packages/thirdweb/src/utils/any-evm/deploy-metadata.ts
@@ -96,7 +96,7 @@ export async function fetchBytecodeFromCompilerMetadata(options: {
       return deployBytecode;
     },
     {
-      cacheKey: `bytecode:${compilerMetadata.name}:${chain.id}`,
+      cacheKey: `bytecode:${compilerMetadata.name}:${compilerMetadata.publisher}:${compilerMetadata.version}:${chain.id}`,
       cacheTime: 24 * 60 * 60 * 1000,
     },
   );