Version Packages #8281
Version Packages #8281
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughCoordinated version bumps and changelog additions across multiple packages, plus removal of two changeset files; includes a changelog entry documenting a Vite "process not defined" import fix for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Version header added; consider documenting the rationale.While the version 0.2.168 header follows the existing file pattern (several versions have headers only), adding a minimal Patch Changes section explaining the version bump—such as "Updated dependencies to @thirdweb-dev/wagmi-adapter@0.2.168"—would improve clarity for future maintainers and consistency with release documentation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (9)
.changeset/small-taxes-heal.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/small-taxes-heal.md
🧰 Additional context used
📓 Path-based instructions (2)
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/nebula/package.jsonpackages/wagmi-adapter/package.jsonpackages/thirdweb/package.jsonapps/wagmi-demo/package.json
packages/wagmi-adapter/**
📄 CodeRabbit inference engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/package.jsonpackages/wagmi-adapter/CHANGELOG.md
🧠 Learnings (1)
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/package.jsonpackages/wagmi-adapter/CHANGELOG.mdapps/wagmi-demo/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Size
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Build Packages
- GitHub Check: Lint Packages
- GitHub Check: Socket Security: Pull Request Alerts
- GitHub Check: Analyze (javascript)
🔇 Additional comments (6)
packages/nebula/CHANGELOG.md (1)
3-8: Changelog entry properly formatted and consistent.The version 0.2.71 entry correctly documents the dependency update to thirdweb@5.109.2 with the matching commit hash.
packages/wagmi-adapter/package.json (1)
59-59: Version bump is consistent and correct.The version is properly updated to 0.2.168, matching the CHANGELOG entry and dependency references in dependent packages.
apps/wagmi-demo/CHANGELOG.md (1)
3-9: Changelog entry properly documents dependency updates.Version 0.0.13 correctly lists both updated dependencies (thirdweb@5.109.2 and @thirdweb-dev/wagmi-adapter@0.2.168) with the matching commit hash, consistent with the version bump in this release.
apps/wagmi-demo/package.json (1)
4-4: Version bump looks good.The patch version increment from 0.0.12 to 0.0.13 is appropriate for a demo app following dependency updates. Workspace dependencies are correctly specified.
packages/nebula/package.json (1)
60-60: Version bump is correct.The patch version increment from 0.2.70 to 0.2.71 reflects the updated dependency on thirdweb@5.109.2. Workspace reference ensures proper resolution.
packages/thirdweb/package.json (1)
433-433: Version bump is appropriate.The patch increment from 5.109.1 to 5.109.2 correctly reflects a bug fix release (Vite import error, per PR #8280). No changes to public exports or dependencies. Size-limit tooling and scripts remain intact.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8281 +/- ##
=======================================
Coverage 54.90% 54.90%
=======================================
Files 919 919
Lines 60665 60665
Branches 4128 4129 +1
=======================================
+ Hits 33309 33310 +1
Misses 27254 27254
+ Partials 102 101 -1
🚀 New features to boost your workflow:
|
size-limit report 📦
|
joaquim-verges
force-pushed
the
changeset-release/main
branch
from
bbc6717 to
055dbfa
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/thirdweb/package.json (1)
56-56: Addsize-limitconfiguration to track bundle budgets.The package has
size-limitand@size-limit/preset-big-libin devDependencies, but there's no correspondingsize-limitconfiguration field inpackage.jsonto define bundle budgets. Per coding guidelines, bundle budgets should be tracked viapackage.json#size-limit.Add a
size-limitconfiguration field to define bundle budget constraints. For example:"sideEffects": false, "type": "module", "types": "./dist/types/exports/thirdweb.d.ts", + "size-limit": [ + { + "path": "./dist/esm/exports/thirdweb.js", + "limit": "100 kB" + } + ], "typesVersions": {If budgets are defined in a separate config file (
.size-limit.json), this is optional.Also applies to: 91-91
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (11)
.changeset/small-taxes-heal.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/api/CHANGELOG.md(1 hunks)packages/api/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/small-taxes-heal.md
✅ Files skipped from review due to trivial changes (4)
- apps/wagmi-demo/package.json
- packages/nebula/CHANGELOG.md
- packages/api/package.json
- packages/api/CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (3)
- apps/wagmi-demo/CHANGELOG.md
- packages/wagmi-adapter/package.json
- packages/nebula/package.json
🧰 Additional context used
📓 Path-based instructions (2)
packages/wagmi-adapter/**
📄 CodeRabbit inference engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/CHANGELOG.md
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/thirdweb/package.json
🧠 Learnings (1)
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Size
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Changelog entry is correctly formatted and positioned.The new version header 0.2.168 is properly added at the top of the changelog with appropriate markdown formatting and follows the established pattern. The absence of release notes aligns with the PR objectives noting "no additional notes" for this version.
packages/thirdweb/package.json (1)
433-433: Version bump is correct and aligns with PR objectives.The patch version bump from 5.109.1 to 5.109.2 is semantically correct and matches the changelog entry documenting the Vite "process not defined" fix.
joaquim-verges
force-pushed
the
changeset-release/main
branch
from
055dbfa to
98dc916
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/api/package.json (1)
1-61: Consider adding bundle size tracking.As per coding guidelines, bundle budgets should be tracked via
package.json#size-limit. This package lacks asize-limitfield. If bundle monitoring is required for this package, add the field to align with best practices.Example configuration:
{ "size-limit": [ { "path": "dist/esm/**/*.js", "limit": "10 KB" } ] }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (12)
.changeset/breezy-heads-crash.md(0 hunks).changeset/small-taxes-heal.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/api/CHANGELOG.md(1 hunks)packages/api/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (2)
- .changeset/breezy-heads-crash.md
- .changeset/small-taxes-heal.md
🚧 Files skipped from review as they are similar to previous changes (9)
- apps/wagmi-demo/CHANGELOG.md
- packages/nebula/package.json
- packages/nebula/CHANGELOG.md
- apps/wagmi-demo/package.json
- packages/api/CHANGELOG.md
- packages/wagmi-adapter/CHANGELOG.md
- packages/thirdweb/CHANGELOG.md
- packages/wagmi-adapter/package.json
- packages/thirdweb/package.json
🧰 Additional context used
📓 Path-based instructions (1)
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/api/package.json
🧠 Learnings (1)
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API
Applied to files:
packages/api/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Size
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Lint Packages
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
packages/api/package.json (1)
3-3: Verify version bump classification for API changes.The PR notes "Added support for userId across wallet APIs," which may constitute a new or modified public API. Per versioning guidelines, such changes typically warrant a minor version bump rather than a patch. Confirm whether the userId addition is backward-compatible or introduces breaking changes.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
thirdweb@5.110.0
Minor Changes
#8289
b30369fThanks @jnsdls! - ###getContractMetadata()now returns a record withunknownvalues instead ofany.before:
after:
Metadata is not (and was never) strictly defined outside of
nameandsymboland may contain any type of data in the record.This is not a runtime change but it may break type inference in existing apps that relied on the previous return type.
Recommended fix:
You should type-guard any key you access from "metadata".
Quick fix:
If adding type assertions is not something you can do in the short term you can also assert the type directly.
This is as "unsafe" as the type was before.
Patch Changes
ceba683Thanks @MananTank! - Fix process not defined error when using "thirdweb/contract" import in Vite@thirdweb-dev/api@0.1.1
Patch Changes
f2121e9Thanks @0xFirekeeper! - added support for userId across wallet apis@thirdweb-dev/nebula@0.2.71
Patch Changes
ceba683,b30369f]:@thirdweb-dev/wagmi-adapter@0.2.168
wagmi-inapp@0.0.13
Patch Changes
ceba683,b30369f]:PR-Codex overview
This PR focuses on version updates across various packages, including
thirdweb,wagmi-adapter, andapi, along with notable changes inCHANGELOG.mdfiles. It also introduces a type change in thegetContractMetadata()function.Detailed summary
versioninpackages/thirdweb/package.jsonto5.110.0.versioninapps/wagmi-demo/package.jsonto0.0.13.versioninpackages/nebula/package.jsonto0.2.71.versioninpackages/wagmi-adapter/package.jsonto0.2.168.versioninpackages/api/package.jsonto0.1.1.CHANGELOG.mdfornebula,api,wagmi-demo, andthirdweb, detailing patch changes and updates.getContractMetadata()toRecord<string, unknown>fromRecord<string, any>, impacting type inference.Summary by CodeRabbit
Bug Fixes
New Features
Updates
getContractMetadata()return type toRecord<string, unknown>(may affect type inference; see documentation for type-guarding guidance)Chores