Skip to content

Update implementations #8334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
+9 −4
Merged

Update implementations #8334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hot-pets-tie.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

Update implementations
8 changes: 4 additions & 4 deletions packages/thirdweb/src/contract/deployment/zksync/implementations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
export const ZKSYNC_IMPLEMENTATIONS: Record<number, Record<string, string>> = {
232: {
MarketplaceV3: "0x9742f5ac11958cFAd151eBF0Fc31302fA409036E",
MarketplaceV3: "0xB7387cF425eC8Da1b04b8E34De86245cb32bCA6D",
},
300: {
MarketplaceV3: "0x58e0F289C7dD2025eBd0696d913ECC0fdc1CC8bc",
Expand All @@ -18,7 +18,7 @@ export const ZKSYNC_IMPLEMENTATIONS: Record<number, Record<string, string>> = {
MarketplaceV3: "0x2dA4Dd326A6482679547071be21f74685d730504",
},
37111: {
MarketplaceV3: "0x56Abb6a3f25DCcdaDa106191053b1CC54C196DEE",
MarketplaceV3: "0xF8fd1016420c2B7832714241d36Efe55D41df126",
},
50104: {
MarketplaceV3: "0x292c324920d4120F928dA6f04548442fa10B8B0f",
Expand All @@ -32,12 +32,12 @@ export const ZKSYNC_IMPLEMENTATIONS: Record<number, Record<string, string>> = {
};

export const ZKSYNC_WETH: Record<number, string> = {
232: "0xE5ecd226b3032910CEaa43ba92EE8232f8237553",
232: "0x6bDc36E20D267Ff0dd6097799f82e78907105e2F",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify that the updated WETH addresses are the canonical wrapped ETH contracts.

The WETH contract addresses for chains 232 and 37111 have been updated. Since WETH is a critical infrastructure token, confirm these addresses point to the official/canonical WETH implementations for these chains.

Run the following script to verify the WETH contract addresses:

Also applies to: 40-40

🏁 Script executed:

#!/bin/bash
# Description: Verify WETH contract addresses on chains 232 and 37111

echo "Verifying WETH addresses..."

# Chain 232
echo -e "\n=== Chain 232 ==="
echo "Address: 0x6bDc36E20D267Ff0dd6097799f82e78907105e2F"

# Chain 37111
echo -e "\n=== Chain 37111 ==="
echo "Address: 0xeee5a340Cdc9c179Db25dea45AcfD5FE8d4d3eB8"

# Suggest manual verification steps
echo -e "\nPlease verify these addresses on the respective block explorers:"
echo "1. Confirm these are the canonical WETH contracts for each chain"
echo "2. Verify contract implementation matches WETH9 or equivalent"
echo "3. Check contract verification status"
echo "4. Validate these match official chain documentation"

Length of output: 455

I need to identify what chains these are and verify the WETH addresses. Let me search for information about these chains and their canonical WETH contracts.

I need to clarify what chains 232 and 37111 represent to properly verify these WETH addresses.

Based on my web searches, Lens is a Layer 2 blockchain that is built using zkSync's ZK Stack, and Chain 232 corresponds to Lens Network. However, I haven't been able to identify what chain 37111 represents. Let me search the codebase to understand the context better and verify these addresses.

Review requires manual verification — Chain 37111 identity is not readily identifiable via web search.

I've verified that Lens is a Layer 2 blockchain that is built using zkSync's ZK Stack, confirming Chain 232 is Lens Network. However, I cannot definitively identify Chain 37111 through publicly available information. Additionally, I was unable to locate the specific canonical WETH addresses for these chains to verify that the provided addresses are correct implementations.

🏁 Script executed:

#!/bin/bash
# Find references to chain 37111 and WETH addresses in codebase
echo "=== Searching for chain 37111 ===" 
rg "37111" -C3

echo -e "\n=== Searching for old WETH addresses ===" 
rg "0x6bDc36E20D267Ff0dd6097799f82e78907105e2F|0xeee5a340Cdc9c179Db25dea45AcfD5FE8d4d3eB8" -C2

echo -e "\n=== Looking at the implementations file ===" 
fd "implementations.ts" --path "*zksync*" -x head -50 {}

Length of output: 5836

Now I understand the context better. Chain 37111 is Lens Sepolia (testnet) and Chain 232 is Lens Mainnet. Both are zkSync Stack-based chains. Let me search for the official WETH addresses for these Lens networks.

🌐 Web query:

Lens Network mainnet WETH contract address

💡 Result:

Lens Chain (mainnet) WETH: 0xE5ecd226b3032910CEaa43ba92EE8232f8237553. [1][2]

Sources:
[1] Lens Docs — Deployed Contracts (Lens Chain Mainnet).
[2] Lens Onboarding Docs — Deployed Contracts (Lens Chain Mainnet).

I found a critical discrepancy. The official WETH address for Lens Chain (mainnet) according to Lens documentation is 0xE5ecd226b3032910CEaa43ba92EE8232f8237553, but Chain 232 in the PR shows 0x6bDc36E20D267Ff0dd6097799f82e78907105e2F. Let me also verify the Lens Sepolia address.

🌐 Web query:

Lens Sepolia testnet WETH contract address

💡 Result:

Lens testnet WETH: 0xaA91D645D7a6C1aeaa5988e0547267B77d33fe16. [1]

Sources:
[1] Lens documentation — Deployed Contracts (Lens Chain Testnet).

Replace both WETH addresses with the official Lens Network contracts.

The WETH addresses are incorrect according to official Lens documentation:

  • Chain 232 (Lens Mainnet): Replace 0x6bDc36E20D267Ff0dd6097799f82e78907105e2F with 0xE5ecd226b3032910CEaa43ba92EE8232f8237553 (per Lens Docs)
  • Chain 37111 (Lens Sepolia): Replace 0xeee5a340Cdc9c179Db25dea45AcfD5FE8d4d3eB8 with 0xaA91D645D7a6C1aeaa5988e0547267B77d33fe16 (per Lens documentation)
🤖 Prompt for AI Agents 
In packages/thirdweb/src/contract/deployment/zksync/implementations.ts around
lines 35-35, the WETH addresses for Lens Mainnet (chainId 232) and Lens Sepolia
(chainId 37111) are incorrect; update the entry for chain 232 to use
0xE5ecd226b3032910CEaa43ba92EE8232f8237553 and the entry for chain 37111 to use
0xaA91D645D7a6C1aeaa5988e0547267B77d33fe16 (replace the existing addresses),
keeping checksum casing exactly as provided and preserving surrounding object
structure and formatting.

300: "0x0462C05457Fed440740Ff3696bDd2D0577411e34",
324: "0x5AEa5775959fBC2557Cc8789bC1bf90A239D9a91",
2741: "0x3439153EB7AF838Ad19d56E1571FBD09333C2809",
11124: "0x9EDCde0257F2386Ce177C3a7FCdd97787F0D841d",
37111: "0xaA91D645D7a6C1aeaa5988e0547267B77d33fe16",
37111: "0xeee5a340Cdc9c179Db25dea45AcfD5FE8d4d3eB8",
50104: "0x2b1A859dE6A55c553520D7780Bc5805712B128F9",
555271: "0xb0b8b267d44c64BA6dD1Daf442949887c85199f6",
531050104: "0x9B7EA63EF5062661570afe548e3AD691D5652527",
Expand Down
Loading