Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Nov 7, 2025


PR-Codex overview

This PR focuses on updating the X402RightSection component by removing a specific value and modifying how chainId is set in the searchParams.

Detailed summary

  • Removed the line with BigInt(1 * 10 ** 18).
  • Updated the searchParams to set chainId using props.options.chain.id.toString().

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Release Notes

  • Refactor
    • Removed hardcoded payment parameter from payment processing flow, allowing for more flexible payment amount handling.

@vercel
Copy link

vercel bot commented Nov 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thirdweb_playground Ready Ready Preview Comment Nov 7, 2025 10:39am
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs-v2 Skipped Skipped Nov 7, 2025 10:39am
nebula Skipped Skipped Nov 7, 2025 10:39am
thirdweb-www Skipped Skipped Nov 7, 2025 10:39am
wallet-ui Skipped Skipped Nov 7, 2025 10:39am

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 7, 2025 10:34 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www November 7, 2025 10:34 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2025

⚠️ No Changeset found

Latest commit: 1fbd03b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – nebula November 7, 2025 10:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 7, 2025 10:35 Inactive
@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Nov 7, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 7, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

A hardcoded payment amount parameter BigInt(1 * 10 ** 18) was removed from the wrapFetchWithPayment function call in the X402RightSection component. All logic and error handling remain intact.

Changes

Cohort / File(s) Change Summary
X402 Component Parameter Removal
apps/playground-web/src/app/payments/x402/components/X402RightSection.tsx
Removed the explicit BigInt(1 * 10 ** 18) payment amount argument from the wrapFetchWithPayment call in the paidApiCall mutation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify that wrapFetchWithPayment properly handles the missing parameter via defaults or internal logic
  • Confirm that removing this hardcoded amount doesn't break the payment flow
  • Check that no other components depend on this explicit parameter being passed
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch _X402_Remove_hardcoded_BigInt_parameter_from_wrapFetchWithPayment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c9e430d and 1fbd03b.

📒 Files selected for processing (1)
  • apps/playground-web/src/app/payments/x402/components/X402RightSection.tsx (0 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.64%. Comparing base (c9e430d) to head (1fbd03b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8376   +/-   ##
=======================================
  Coverage   54.64%   54.64%           
=======================================
  Files         919      919           
  Lines       60704    60704           
  Branches     4113     4113           
=======================================
  Hits        33171    33171           
  Misses      27431    27431           
  Partials      102      102           
Flag Coverage Δ
packages 54.64% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges changed the title [X402] Remove hardcoded BigInt parameter from wrapFetchWithPayment [Playground] Remove hardcoded limit from wrapFetchWithPayment Nov 7, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review November 7, 2025 10:38
@joaquim-verges joaquim-verges requested review from a team as code owners November 7, 2025 10:38
@joaquim-verges joaquim-verges merged commit 11c7bf0 into main Nov 7, 2025
25 of 26 checks passed
@joaquim-verges joaquim-verges deleted the _X402_Remove_hardcoded_BigInt_parameter_from_wrapFetchWithPayment branch November 7, 2025 10:38
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 104.88 KB (0%)
@thirdweb-dev/nexus (cjs) 316.6 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Playground Changes involving the Playground codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants