Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Nov 10, 2025


Fixes #8387

PR-Codex overview

This PR focuses on loosening the peer dependency requirements for @react-native-async-storage/async-storage, expo-application, expo-linking, and expo-web-browser, allowing for broader compatibility. It also updates various package versions, including expo and react-native.

Detailed summary

  • Updated @react-native-async-storage/async-storage to "*" from "^1 || ^2".
  • Updated expo-application, expo-linking, and expo-web-browser to "*" from specific version ranges.
  • Changed expo-linking version from 7.0.5 to 8.0.8.
  • Changed expo-web-browser version from 14.0.2 to 15.0.9.
  • Loosened peer dependency requirements for react-native to "*" in packages/thirdweb/package.json.
  • Updated @mobile-wallet-protocol/client version in pnpm-lock.yaml.
  • Changed various package versions in pnpm-lock.yaml for consistency and compatibility.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Chores
    • Improved React Native ecosystem compatibility by relaxing peer dependency version constraints for Expo and async storage packages
    • Updated Expo-related dependencies to latest stable releases
    • Enhanced flexibility for developers using varying versions of compatible libraries

@vercel
Copy link

vercel bot commented Nov 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Ready Preview Comment Nov 10, 2025 6:53pm
nebula Ready Ready Preview Comment Nov 10, 2025 6:53pm
thirdweb_playground Ready Ready Preview Comment Nov 10, 2025 6:53pm
thirdweb-www Ready Ready Preview Comment Nov 10, 2025 6:53pm
wallet-ui Ready Ready Preview Comment Nov 10, 2025 6:53pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2025

🦋 Changeset detected

Latest commit: 2bcef37

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@thirdweb-dev/react-native-adapter Patch
thirdweb Patch
@thirdweb-dev/nebula Patch
@thirdweb-dev/wagmi-adapter Patch
wagmi-inapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Nov 10, 2025
@joaquim-verges joaquim-verges changed the title Loosen peer dependency requirements for React Native [SDK] Loosen peer dependency requirements for React Native Nov 10, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review November 10, 2025 18:40
@joaquim-verges joaquim-verges requested review from a team as code owners November 10, 2025 18:40
Copy link
Member Author

joaquim-verges commented Nov 10, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 10, 2025

Walkthrough

This PR adds a changeset declaring patch updates and loosens peer dependency version constraints for Expo packages and React Native async storage across the react-native-adapter and thirdweb packages to increase version compatibility.

Changes

Cohort / File(s) Summary
Changeset Declaration
.changeset/curvy-stars-unite.md
Declares patch-level version bumps for @thirdweb-dev/react-native-adapter and thirdweb, noting relaxed peer dependency requirements for React Native.
Peer Dependency Relaxation
packages/react-native-adapter/package.json, packages/thirdweb/package.json
Loosens peerDependency constraints by replacing specific version ranges with wildcards (*) for @react-native-async-storage/async-storage, expo-application, expo-linking, and expo-web-browser. Additionally, packages/thirdweb/package.json updates direct and dev dependencies for expo-linking (7.0.5 → 8.0.8) and expo-web-browser (14.0.2 → 15.0.9).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Verify that wildcard peer dependency constraints do not introduce unintended compatibility issues with existing consumers
  • Confirm that version bumps for expo packages in packages/thirdweb/package.json are compatible with the relaxed constraints in packages/react-native-adapter/package.json
  • Validate that the changeset properly reflects the nature and scope of the version updates

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely blank/commented-out; required sections like title, issue tag, notes for reviewer, and testing instructions are completely missing. Fill in all required sections: add a properly formatted title following '[SDK/Dashboard/Portal] Feature/Fix' pattern, include the Linear issue tag (TEAM-####), provide notes for the reviewer, and describe how to test the changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'Loosen peer dependency requirements for React Native' directly and accurately summarizes the main change in the PR.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch Loosen_peer_dependency_requirements_for_React_Native

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedexpo-linking@​7.0.5 ⏵ 8.0.8100 +110080 +1100 +1100
Updatedexpo-web-browser@​14.0.2 ⏵ 15.0.910010085 +1100100

View full report

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 104.88 KB (0%)
@thirdweb-dev/nexus (cjs) 316.6 KB (0%)

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.77%. Comparing base (424e6b8) to head (2bcef37).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8390   +/-   ##
=======================================
  Coverage   54.77%   54.77%           
=======================================
  Files         919      919           
  Lines       60768    60768           
  Branches     4119     4121    +2     
=======================================
  Hits        33284    33284           
  Misses      27382    27382           
  Partials      102      102           
Flag Coverage Δ
packages 54.77% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit f964b8a into main Nov 10, 2025
24 of 26 checks passed
@joaquim-verges joaquim-verges deleted the Loosen_peer_dependency_requirements_for_React_Native branch November 10, 2025 18:47
@joaquim-verges joaquim-verges mentioned this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants