From 9442dc7729749d61569aaff9fc77cdac9225ccbf Mon Sep 17 00:00:00 2001
From: joaquim-verges <joaquim.verges@gmail.com>
Date: Wed, 12 Nov 2025 22:46:32 +0000
Subject: [PATCH] [SDK] Rename otherWallets to allConnectedWallets in onConnect
 callback (#8407)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the `onConnect` callback in the `AutoConnect` component to improve clarity in variable naming, changing `otherWallets` to `allConnectedWallets`.

### Detailed summary
- Changed the parameter name in `onConnect` from `otherWallets` to `allConnectedWallets`.
- Updated the console log statement to reflect the new parameter name, changing it from "other wallets that were also connected" to "all connected wallets".

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **Breaking Changes**
  * Updated parameter naming in the AutoConnect callback configuration to align with updated documentation.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---
 packages/thirdweb/src/wallets/connection/types.ts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/packages/thirdweb/src/wallets/connection/types.ts b/packages/thirdweb/src/wallets/connection/types.ts
index 30aa59ed65e..56ccd8cea77 100644
--- a/packages/thirdweb/src/wallets/connection/types.ts
+++ b/packages/thirdweb/src/wallets/connection/types.ts
@@ -101,14 +101,14 @@ export type AutoConnectProps = {
    *
    * ```tsx
    * <AutoConnect
-   *  onConnect={(activeWallet, otherWallets) => {
+   *  onConnect={(activeWallet, allConnectedWallets) => {
    *    console.log("auto connected to", activeWallet)
-   *    console.log("other wallets that were also connected", otherWallets)
+   *    console.log("all connected wallets", allConnectedWallets)
    *  }}
    * />
    * ```
    */
-  onConnect?: (activeWallet: Wallet, otherWallets: Wallet[]) => void;
+  onConnect?: (activeWallet: Wallet, allConnectedWallets: Wallet[]) => void;
 
   /**
    * Optional chain to autoconnect to