Version Packages #8458
Version Packages #8458
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughPackage version increments and corresponding changelog updates across multiple packages (wagmi-demo 0.0.37, nebula 0.2.95, thirdweb 5.114.0, wagmi-adapter 0.2.192). The thirdweb changelog documents a new "upto" payment scheme for x402 verify/settle flow. A related changeset documentation file is deleted as part of the release process. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Suggested labels
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
packages/thirdweb/CHANGELOG.md (5)
10-19: Clarifypricetype/units for the max verification amount.You set
price: "$0.10"in verify, but later pass a number tosettlePayment. If both are supported, call it out; otherwise, keep the type consistent and specify currency/units (e.g., USD cents or token base units) to avoid confusion. Consider renaming the comment to “max amount” to reinforce the cap semantics.
33-39: Avoid floating‑point money math in the example.Using
0.00001risks precision drift. Prefer integer minor units (e.g., cents, wei) or a decimal library. Example:- const { tokensUsed } = await doExpensiveWork(); - const pricePerTokenUsed = 0.00001; + const { tokensUsed } = await doExpensiveWork(); + // work in minor units to avoid float errors + const pricePerTokenUsedMicros = 10n; // 0.000010 in "micro‑units" + const finalPriceMicros = BigInt(tokensUsed) * pricePerTokenUsedMicros;Then convert to the expected
priceformat before callingsettlePayment.
24-29: Broaden the success check.
status === 200is brittle; prefer accepting any 2xx or anokboolean if available:- if (verifyResult.status !== 200) { + if (!(verifyResult.status >= 200 && verifyResult.status < 300)) {This keeps the snippet correct if the API returns 201/204, etc.
9-19: Add minimal imports to make the snippet self‑contained.Readers will copy/paste this. Suggest adding (or a comment noting) needed imports:
import { arbitrum } from "thirdweb/chains"; import { verifyPayment, settlePayment } from "thirdweb/payments"; // adjust path if differentIf using Fetch API Response, note the runtime (e.g., Next.js/edge).
35-39: State the cap invariant explicitly.Add a one‑liner that
settlePaymentmust not exceed the previously verified max when usingscheme: "upto", and that the backend should enforce/validate this. Helps prevent misuse.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (9)
.changeset/chilly-taxis-search.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/chilly-taxis-search.md
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{js,jsx,ts,tsx,json}
📄 CodeRabbit inference engine (AGENTS.md)
Biome governs formatting and linting; its rules live in biome.json. Run
pnpm fix&pnpm lintbefore committing, ensure there are no linting errors
Files:
packages/nebula/package.jsonapps/wagmi-demo/package.jsonpackages/thirdweb/package.jsonpackages/wagmi-adapter/package.json
packages/thirdweb/package.json
📄 CodeRabbit inference engine (CLAUDE.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/thirdweb/package.json
🧠 Learnings (6)
📓 Common learnings
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-24T22:45:01.202Z
Learning: Applies to packages/**/.changeset/*.md : Each change in packages/* should contain a changeset for the appropriate package with the appropriate version bump: patch for changes that don't impact the public API, minor for any new/modified public API
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T22:43:43.644Z
Learning: Run `pnpm changeset` after making changes in `packages/*` for semantic versioning
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-24T22:45:01.202Z
Learning: Surface breaking changes prominently in PR descriptions
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T22:43:43.644Z
Learning: Surface breaking changes prominently in PR descriptions
📚 Learning: 2025-11-24T22:45:01.202Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-24T22:45:01.202Z
Learning: Applies to packages/**/.changeset/*.md : Each change in packages/* should contain a changeset for the appropriate package with the appropriate version bump: patch for changes that don't impact the public API, minor for any new/modified public API
Applied to files:
packages/nebula/CHANGELOG.mdapps/wagmi-demo/CHANGELOG.mdpackages/wagmi-adapter/CHANGELOG.mdpackages/thirdweb/CHANGELOG.md
📚 Learning: 2025-11-24T22:43:43.644Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T22:43:43.644Z
Learning: Use `patch` version bump for changes that don't impact the public API
Applied to files:
packages/nebula/CHANGELOG.mdapps/wagmi-demo/CHANGELOG.mdpackages/thirdweb/package.json
📚 Learning: 2025-11-24T22:45:01.202Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-24T22:45:01.202Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Export everything in packages/thirdweb via the exports/ directory, grouped by feature. Every public symbol must have comprehensive TSDoc including at least one example block that compiles and one custom annotation (beta, internal, experimental, etc.)
Applied to files:
packages/nebula/package.jsonpackages/thirdweb/package.jsonpackages/wagmi-adapter/package.json
📚 Learning: 2025-11-24T22:43:43.644Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T22:43:43.644Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Export everything via `exports/` directory, grouped by feature in SDK development
Applied to files:
packages/nebula/package.jsonpackages/thirdweb/package.jsonpackages/wagmi-adapter/package.json
📚 Learning: 2025-11-24T22:43:43.644Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T22:43:43.644Z
Learning: Run `pnpm changeset` after making changes in `packages/*` for semantic versioning
Applied to files:
apps/wagmi-demo/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Unit Tests
- GitHub Check: Lint Packages
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (7)
packages/nebula/package.json (1)
60-60: Version bump correct for patch release.The patch version increment (0.2.94 → 0.2.95) properly reflects a dependency-only update with no API changes, aligning with the updated thirdweb dependency documented in the changelog.
packages/thirdweb/package.json (1)
433-433: Minor version bump appropriate for new payment scheme feature.The version increment (5.113.0 → 5.114.0) correctly reflects the new "upto" payment scheme option added for x402 verify/settle flows, which represents a public API addition warranting a minor version bump.
packages/wagmi-adapter/package.json (1)
59-59: Patch version bump correct for dependency-only release.The version increment (0.2.191 → 0.2.192) properly reflects a dependency update with no direct API changes to the adapter itself.
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Changelog entry properly formatted as empty release.The version header is correctly placed with no documented changes, consistent with the PR objectives indicating no changelog entries for this patch release. This pattern aligns with standard Changesets automation for dependency-only updates.
packages/nebula/CHANGELOG.md (1)
3-9: Changelog entry properly formatted with dependency update documented.The patch release entry correctly documents the thirdweb@5.114.0 dependency update with commit reference, following the established changelog format throughout the file.
apps/wagmi-demo/CHANGELOG.md (1)
3-9: Changelog entry properly documents all dependency updates.The patch release correctly lists both updated dependencies (thirdweb@5.114.0 and @thirdweb-dev/wagmi-adapter@0.2.192) with commit reference, following the established format in the changelog.
apps/wagmi-demo/package.json (1)
4-4: Patch version bump appropriate for dependency updates.The version increment (0.0.36 → 0.0.37) correctly reflects dependency updates to both thirdweb and wagmi-adapter without direct API changes to the demo app itself.
size-limit report 📦
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
thirdweb@5.114.0
Minor Changes
#8457
35aaf24Thanks @joaquim-verges! - Add "upto" payment scheme option for x402 verify and settle@thirdweb-dev/nebula@0.2.95
Patch Changes
35aaf24]:@thirdweb-dev/wagmi-adapter@0.2.192
wagmi-inapp@0.0.37
Patch Changes
35aaf24]:PR-Codex overview
This PR focuses on updating version numbers across multiple packages and adding new changelog entries, including a minor feature for a payment scheme in the
thirdwebpackage.Detailed summary
.changeset/chilly-taxis-search.md.packages/thirdweb/package.jsonfrom5.113.0to5.114.0.apps/wagmi-demo/package.jsonfrom0.0.36to0.0.37.packages/nebula/package.jsonfrom0.2.94to0.2.95.packages/wagmi-adapter/package.jsonfrom0.2.191to0.2.192.packages/nebula(0.2.95),apps/wagmi-demo(0.0.37), andpackages/thirdweb(5.114.0).thirdwebwith example code for dynamic pricing.Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.