Skip to content

Conversation

@0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Dec 5, 2025

Introduces a new MDX guide for Solana facilitator integration under x402, detailing setup and API usage. Updates the sidebar to include a link to the new Solana guide for easier navigation.


PR-Codex overview

This PR introduces support for the Solana network in the x402 payments system, adding new functionality and documentation to facilitate transactions through a Solana facilitator wallet.

Detailed summary

  • Added a new entry for Solana in the sidebar of x402.
  • Created page.mdx for Solana Facilitator with:
    • Metadata for title, icon, and description.
    • Overview of Solana support for payments.
    • Features including wallet creation and transaction settlement.
    • Step-by-step guide for setting up and using the Solana facilitator wallet.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Documentation

    • Added a comprehensive Solana Facilitator guide for x402 payments with overview, supported networks, end-to-end fast-start instructions, code samples, and integration steps (quoting, verification, on-chain settlement, and protected resource fetching).
  • New Features

    • Added a "Solana" link to the x402 Guides navigation for quick access to the new documentation.

✏️ Tip: You can customize this high-level summary in your review settings.

Introduces a new MDX guide for Solana facilitator integration under x402, detailing setup and API usage. Updates the sidebar to include a link to the new Solana guide for easier navigation.
@0xFirekeeper 0xFirekeeper requested review from a team as code owners December 5, 2025 22:38
@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2025

⚠️ No Changeset found

Latest commit: edd7135

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Ready Preview Comment Dec 5, 2025 11:04pm
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
nebula Skipped Skipped Dec 5, 2025 11:04pm
thirdweb_playground Skipped Skipped Dec 5, 2025 11:04pm
thirdweb-www Skipped Skipped Dec 5, 2025 11:04pm
wallet-ui Skipped Skipped Dec 5, 2025 11:04pm

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Dec 5, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 5, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds a new MDX documentation page describing Solana Facilitator support for x402 payments and a sidebar entry linking to it; the page includes exported metadata, supported networks, endpoints, and an end-to-end integration guide with examples.

Changes

Cohort / File(s) Summary
New Solana Facilitator Documentation
apps/portal/src/app/x402/facilitator/solana/page.mdx
New MDX page introducing Solana Facilitator for x402 payments. Imports Callout and createMetadata, exports metadata = createMetadata({ image, title, description }), and documents supported networks, endpoints (/v1/payments/x402/accepts, /verify, /settle, /fetch), quick-start steps, code samples, and callouts.
Sidebar Navigation Update
apps/portal/src/app/x402/sidebar.tsx
Added a "Solana" guide link under the x402 Guides section pointing to /x402/facilitator/solana.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Review focus:
    • Ensure createMetadata and Callout imports resolve and the exported metadata shape matches portal conventions.
    • Confirm sidebar route /x402/facilitator/solana matches routing and navigation structure.
    • Quick scan for MDX syntax correctness and example accuracy (endpoints, headers, payloads).

Possibly related PRs

  • Add Solana facilitator guide to docs #8511 — Appears to add the same MDX page and sidebar link (apps/portal/src/app/x402/facilitator/solana/page.mdx and apps/portal/src/app/x402/sidebar.tsx), likely the same or closely related change.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description provides a clear overview of changes but lacks key template sections like issue tag, detailed notes for reviewers, and testing instructions. Add the Linear issue tag (TEAM-xxxx format), expand notes for reviewers section with important implementation details, and include specific testing instructions (e.g., manual verification steps or unit tests).
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add Solana facilitator guide to docs' directly and clearly summarizes the main change: adding documentation for Solana facilitator support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between fb2c0fc and edd7135.

📒 Files selected for processing (1)
  • apps/portal/src/app/x402/facilitator/solana/page.mdx (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.65%. Comparing base (7b873d3) to head (edd7135).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8511   +/-   ##
=======================================
  Coverage   54.65%   54.65%           
=======================================
  Files         920      920           
  Lines       61114    61114           
  Branches     4145     4145           
=======================================
  Hits        33399    33399           
  Misses      27613    27613           
  Partials      102      102           
Flag Coverage Δ
packages 54.65% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
apps/portal/src/app/x402/facilitator/solana/page.mdx (3)

30-50: Call out that x-secret-key must stay server-side

The examples correctly show server-side usage, but it’s easy for readers to paste this into client code. I’d recommend adding a short note right after this first snippet that x-secret-key must never be exposed in browser/mobile clients and should only be used from trusted server environments.


114-147: Make the final step heading consistent with prior numbered steps

You use numbered headings for steps 1–4, then switch to ### Fetch protected resources without a step number. For consistency and skim-ability, consider renaming this to something like ### 5. Fetch protected resources.


68-76: Clarify which Solana cluster the network/chainId example targets

The network and chainId values ("solana:8E9rvCKLFQia2Y35HXjjpWzj8weVo44K") look like a specific Solana cluster identifier, but it’s not obvious to readers whether this is devnet, mainnet, or just an example. It may help to add a brief comment or note indicating the intended cluster and how to choose the correct value for other environments.

Also applies to: 155-156

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7b873d3 and fb2c0fc.

📒 Files selected for processing (2)
  • apps/portal/src/app/x402/facilitator/solana/page.mdx (1 hunks)
  • apps/portal/src/app/x402/sidebar.tsx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each TypeScript file to one stateless, single-responsibility function for clarity
Re-use shared types from @/types or local types.ts barrels
Prefer type aliases over interface except for nominal shapes in TypeScript
Avoid any and unknown in TypeScript unless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial, Pick, etc.) in TypeScript

**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity and testability
Re-use shared types from @/types or local types.ts barrel exports
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics whenever possible
Choose composition over inheritance; leverage utility types (Partial, Pick, etc.)
Comment only ambiguous logic in TypeScript files; avoid restating TypeScript types and signatures in prose

Files:

  • apps/portal/src/app/x402/sidebar.tsx
**/*.{js,jsx,ts,tsx,json}

📄 CodeRabbit inference engine (AGENTS.md)

Biome governs formatting and linting; its rules live in biome.json. Run pnpm fix & pnpm lint before committing, ensure there are no linting errors

Files:

  • apps/portal/src/app/x402/sidebar.tsx
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (AGENTS.md)

Lazy-import optional features; avoid top-level side-effects

Files:

  • apps/portal/src/app/x402/sidebar.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Size
  • GitHub Check: Lint Packages
  • GitHub Check: Vercel Agent Review
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
apps/portal/src/app/x402/sidebar.tsx (1)

40-43: Solana guide link wiring looks correct

The href matches the new page route (/x402/facilitator/solana), and the label fits well under the existing “Facilitator” guide group. No changes needed.

@vercel vercel bot temporarily deployed to Preview – nebula December 5, 2025 22:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 5, 2025 22:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 5, 2025 22:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 5, 2025 22:43 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 105.66 KB (0%)
@thirdweb-dev/nexus (cjs) 319.47 KB (0%)

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 5, 2025 22:53 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 5, 2025 22:53 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 5, 2025 22:53 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula December 5, 2025 22:53 Inactive
@0xFirekeeper 0xFirekeeper merged commit a388439 into main Dec 5, 2025
18 of 19 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/x402-sol branch December 5, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants