Skip to content
Permalink
Branch: 1.1.x
Commits on Oct 8, 2019
  1. AdminPreferences: tone down description for 'Enable SSL' switch.

    Traumflug committed Oct 8, 2019
    Using HTTPS is a normal state of affairs these days, even
    mandatory for production shops.
Commits on Oct 4, 2019
  1. AdminProducts: use sprintf() for formatting error messages.

    Traumflug committed Sep 30, 2019
    Concatenation works for English, other translations may have the
    inserted string elsewhere.
Commits on Oct 2, 2019
  1. Installer: add missing test messages.

    Traumflug committed Oct 2, 2019
    There have been cases with failures detected, but due to a missing
    error message not reported to the user. Which led to a refusal to
    install, without any hint on what's wrong.
    
    See https://forum.thirtybees.com/topic/3512-x
    and https://forum.thirtybees.com/topic/3005-x
  2. Installer: express test messages positively.

    Traumflug committed Oct 2, 2019
    Successful tests get followed by an 'ok', failed tests get a
    'fail' appended, so the description should be positive.
  3. defines.inc.php: simplify.

    Traumflug committed Sep 30, 2019
    This should speed up every request by ~2 microseconds.
Commits on Sep 29, 2019
  1. admin/filemanager: remove PS/tb copyright notices.

    Traumflug committed Sep 29, 2019
    Only from actual vendor files, not from all the added index.php's.
Commits on Sep 25, 2019
  1. ProductSale: eliminate $finalOrderBy.

    Traumflug committed Sep 25, 2019
    The only meaningful value was 'price' and in this case, it was
    always identical to $orderBy.
Commits on Sep 23, 2019
  1. Module: also strip an eventual UTF-8 BOM. Ref #1038

    Traumflug committed Sep 23, 2019
    Based on pull request #1039 by Danila Vershinin <ciapnz@gmail.com>.
    
    Also took the opportunity to join all these trim(), substr() and
    preg_replace() into one preg_replace(), in the hope to reduce
    memory consumption.
Commits on Sep 21, 2019
  1. AdminCountries: clean address format.

    Traumflug committed Sep 21, 2019
     - Trim whitespace from each line.
    
     - Avoid Windows line endings in the database.
Commits on Sep 19, 2019
  1. PageNotFound: send proper image type.

    Traumflug committed Sep 19, 2019
     - We also send WEBP now (and at some point also proper PNG,
       hopefully).
    
     - Type 'image/jpg' doesn't exist, it's 'image/jpeg', see
       https://www.bennadel.com/blog/2609-internet
  2. PageNotFound: replace suffixes, only.

    Traumflug committed Sep 19, 2019
     - Previously, something like 'image.webp.jpg' would get changed
       to 'image.jpg.jpg', which is likely not the intention.
    
     - Also some code formatting.
Commits on Sep 18, 2019
  1. Revert "[-] BO : Fix #PSCSX-7050, wrong pictures shown ..."

    Traumflug committed Sep 18, 2019
    This reverts commit 1e19325.
    
    Original report: http://forge.prestashop.com/browse/PSCSX-7050
    
    It's unclear how a timestamp helps. Each image, even images just
    uploaded, have an individual number, so there should be no cache
    issue. However, such a timestamp apparently messes up Friendly URL
    redirection rules, loading the placeholder image instead of the
    actual one.
    
    See https://forum.thirtybees.com/topic/3493-b-o-timestamped-images-return-404/
Commits on Sep 16, 2019
  1. blocknewproducts: forward module and themes to fix missing images.

    Traumflug committed Sep 16, 2019
    These are the proper fixes to what was tackled with a fallback
    in the previous commit.
  2. ImageType: add another fallback.

    Traumflug committed Sep 16, 2019
    Should solve the issue with broken images discussed here:
    
      https://forum.thirtybees.com/topic/3482-broken-images/
Commits on Sep 9, 2019
  1. AdminProduct: adjust tooltip to reality. Ref #1048.

    Traumflug committed Sep 9, 2019
    '#' and '=' are allowed since a while.
  2. AdminEmail: 80 chars/line (except strings).

    Traumflug committed Sep 9, 2019
  3. AdminEmail: simplify.

    Traumflug committed Sep 9, 2019
    explode() works just fine if there's nothing to explode:
    
      php > var_dump(explode(';', ''));
      php shell code:1:
      array(1) {
        [0] =>
        string(0) ""
      }
      php > var_dump(explode(';', 'a'));
      php shell code:1:
      array(1) {
        [0] =>
        string(1) "a"
      }
      php > var_dump(explode(';', 'a;b'));
      php shell code:1:
      array(2) {
        [0] =>
        string(1) "a"
        [1] =>
        string(1) "b"
      }
  4. PageCache: commenting, formatting.

    Traumflug committed Sep 9, 2019
    80 chars/line, space after cast, @Version, to match other code.
Commits on Sep 6, 2019
  1. AdminThemes: update config.xml after copying of theme, part 3.

    Traumflug committed Aug 28, 2019
    This is related to #655.
  2. AdminThemes: coding style.

    Traumflug committed Aug 27, 2019
Commits on Aug 30, 2019
  1. AdminTranslations: regex '.*\s*' is the same as '.*'.

    Traumflug committed Aug 30, 2019
Commits on Aug 27, 2019
  1. config.inc.php: remove constant TB_OBJECT_MODELS_AUTHORITATIVE.

    Traumflug committed Aug 27, 2019
    This was used in module coreupdater only, which was changed to
    test for the existence of class CoreModels instead. As this
    constant was never in a release, it can get removed without
    retrocompatibility period.
    
    This reverts commit 202e5af.
    
    Also forwarded module coreupdater to the point working without
    this constant.
Commits on Aug 26, 2019
  1. README.md: link to list of known bugs.

    Traumflug committed Aug 26, 2019
Commits on Aug 21, 2019
  1. Employee: don't try to register without email.

    Traumflug committed Aug 21, 2019
  2. ShopMaintenance: read an explicitely global value.

    Traumflug committed Aug 21, 2019
Commits on Aug 15, 2019
  1. build.sh: introduce option --target-dir.

    Traumflug committed Aug 9, 2019
    This should be helpful for test installations. Result verified to
    be identical to a ZIP created the former way, unpacked into an
    empty diretory.
    
    Unfortunately one can't instruct Composer to not create symbolic
    links, so these have to get resolved "manually".
  2. build.sh: test for a number of prerequisites.

    Traumflug committed Aug 9, 2019
    Copied from buildmodule.sh.
  3. buildmodule.sh: don't trash the target directory.

    Traumflug committed Aug 9, 2019
    Instead, test for its existence.
    
    It should be up to the caller to provide a proper directory for
    packaging. Default is to not store into such a directory, but to
    create a ZIP archive, anyways.
Commits on Aug 14, 2019
  1. Mail templates: there is no 'tools' section in back office.

    Traumflug committed Aug 14, 2019
    Found and reported by @Eleazar on CrowdIn, thank you very much!
  2. Mail templates: remove trailing whitespace.

    Traumflug committed Aug 14, 2019
    Modern code editors remove trailing whitespace automatically, so
    having all this pointless whitespace effectively obfuscates
    actual code changes.
Commits on Aug 12, 2019
  1. build.sh: fix usage description.

    Traumflug committed Aug 8, 2019
    No functional change.
Commits on Aug 8, 2019
  1. README.md: fix Git cloning sample command.

    Traumflug committed Aug 8, 2019
     - Git replaced '--recursive' by '--recurse-submodules'.
    
     - No need for '-b'.
Commits on Aug 2, 2019
  1. ConfigurationTest: change test for TLS v1.2 connectivity.

    Traumflug committed Aug 1, 2019
    As https://tlstest.paypal.com/ apparently ceased to exist, we need
    a distinct method of testing for this kind of connectivity. Using
    some kind of hobby service was discarded for its unknown
    reliability and because such usage could be considered unfair.
    
    New solution is to use https://api.paypal.com directly. One can
    distinguish a connection failure from an authentication failure,
    mission accomplished.
    
    This is related to issue #1007.
Older
You can’t perform that action at this time.