Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong quantity discounts when selling without VAT #264

Closed
elund opened this issue Jun 24, 2017 · 6 comments

Comments

@elund
Copy link

commented Jun 24, 2017

When - for instance - selling to customers outside EU, you should not charge VAT.
But quantity discounts are wrong when selling without VAT, because they always include VAT.
So when checking out, prices are without VAT but quantity discount are with VAT, resulting in too much discounts to the customers.
This is a really old and known bug in PrestaShop, that would be very nice to finally get fixed.

@firstred firstred self-assigned this Jun 26, 2017

@firstred firstred added this to the 1.0.2 milestone Jun 26, 2017

@firstred

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2017

Thank you. I have added the 1.0.2 label, because we want to get this solved with the next release.

@firstred

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2017

This is caused by the fact that it tries to calculate from the total amount of tax applied to the cart (which is always 0 in those cases). From the front office it is not possible to find the original tax.

I am going to add an option on the BO tax page to select the default tax ID, so in case the original tax cannot be found, we can use this tax as a reference. It will be limited to just one tax, though.
taxoptions

If you need to support more taxes, then I suggest to always enter specific price rules without tax and set the tax option to "Tax excluded". This way the catalog price rule tax will become more flexible.

@firstred

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2017

Changes: 70692c2

@firstred firstred added the Resolved label Jun 28, 2017

@firstred firstred closed this Jun 28, 2017

@elund

This comment has been minimized.

Copy link
Author

commented Jun 29, 2017

To test this, is it enough to copy the 2 files (classes/Product.php and controllers/admin/AdminTaxesController.php) to an existing Thirtybees 1.0.1 installation?
I tried and got not errors, but my problem was not resolved?

@firstred

This comment has been minimized.

Copy link
Contributor

commented Jun 29, 2017

Carts and some price calculations are cached. I could only see the updated discounts after clearing all carts.

@Casper-O

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

Is this the "right" solution?

The solution that this person suggested over at prestashop github seems to do the trick, without any limitations like the current work around:

urimarti/Prestashop@cb02974#diff-0a7a17e9ff155e6890d7a5b01eea713c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.