Skip to content

Consistently use NSInteger typedefs #8

Merged
merged 1 commit into from Jan 24, 2014

4 participants

@camdez
camdez commented Jan 13, 2014

NSInteger != int on all platforms; native types (e.g. NSInteger) should generally be preferred for platform agnostic code.

In particular, the library won't compile for armv64 because EDServer's version properties are declared as NSInteger externally, but as int internally. Those are the same thing on 32-bit machine but not a 64-bit machine:

screen shot 2014-01-13 at 3 20 40 pm

Thanks for the great little library!

@camdez camdez Consistently use NSInteger typedefs
NSInteger != int on all platforms; native types (e.g. NSInteger) should
generally be preferred for platform agnostic code.
342e3d4
@mokagio
mokagio commented Jan 16, 2014

+1

@macelangelo

+1

@thisandagain
Owner

👍

@thisandagain thisandagain merged commit cedceaa into thisandagain:master Jan 24, 2014
@thisandagain
Owner

Thanks @camdez I'll get an update to the CocoaPod out today.

@camdez
camdez commented Jan 24, 2014

Fantastic, thanks. Just a quick note: it looks like the v0.2.1 commit (bd99455) never actually made it into master. Could be confusing when you update the podspec this time.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.