Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic sentiment negation #16

Closed
wants to merge 1 commit into from

Conversation

@akumpf
Copy link

commented Dec 16, 2014

This is a pretty simple change that seems to work quite well for most inputs to handle negation.

This accounts for the different between things like "I love cats" and "I don't love cats", "I can't love cats", "I won't love cats".

This approach could be extended to also include double negatives, but let's leave it simple for now.

Add basic sentiment negation
This is a pretty simple change that seems to work quite well for most inputs to handle negation. 

This accounts for the different between things like "I love cats" and "I don't love cats", "I can't love cats", "I won't love cats". 

This approach could be extended to also include double negatives, but let's leave it simple for now.
@thisandagain

This comment has been minimized.

Copy link
Owner

commented Dec 21, 2015

Related to #23

@MichaelPaulukonis

This comment has been minimized.

Copy link

commented Dec 21, 2015

While this implementation doesn't answer many of the questions raised in #23 - it does appear to work, and might be a good candidate for inclusion, with unit-tests, while the more complicated solution is banged out.

Especially since this has been sitting around for a year.

@thisandagain

This comment has been minimized.

Copy link
Owner

commented Dec 22, 2015

@MichaelPaulukonis I agree. I think if we can write some tests and make this behavior optional I'd be happy to land in a 2.0.0-alpha release.

@thisandagain thisandagain referenced this pull request Feb 10, 2017
@thisandagain

This comment has been minimized.

Copy link
Owner

commented Feb 10, 2017

After rebasing this on top of #103, adding negation results in the following (from make validate):

Amazon:   0.7212787212787213 (+~2%)
IMDB:     0.7652347652347652 (+~1%)
Yelp:     0.6943056943056943 (+~2%)
@thisandagain

This comment has been minimized.

Copy link
Owner

commented Feb 10, 2017

Landed with test coverage in fb3dd86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.