Feat/153 changelog #152
Open
Feat/153 changelog #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Author
|
I have pagination done in another upcoming PR for filtering |
Zelig880
reviewed
Nov 26, 2025
| @@ -1,27 +1,40 @@ | |||
| /* Card Wrapper */ | |||
| /* Card Wrapper used in Changelog page */ | |||
There was a problem hiding this comment.
Mobile responsiveness missing. it should look like this:
There was a problem hiding this comment.
There is also too much space between the items on mobile. (not sure if it is too much on desktop too)
Zelig880
reviewed
Nov 26, 2025
| @@ -1,27 +1,40 @@ | |||
| /* Card Wrapper */ | |||
| /* Card Wrapper used in Changelog page */ | |||
There was a problem hiding this comment.
There is also too much space between the items on mobile. (not sure if it is too much on desktop too)
| <div class={clsx(styles.cardWrapper, showBorder && styles.withBorder)} data-expandable="wrapper"> | ||
| <div class={styles.card} data-expandable="card"> | ||
| <div class={styles.header}> | ||
| <div class={styles.metaSection}> |
There was a problem hiding this comment.
This is missing extra info:
Do you need them in the algolia Index?
Feat/155 changelog item page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.Any change needs to be discussed before proceeding.
Closing issues
closes #153 (in algolia search repo)
...
Description
...
Changes