forked from smartcontractkit/documentation
-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/83 remove secondary header #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zelig880
requested changes
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The work is great, but I found something missing:
- Remove the DOC in the "TutorialLayout".
- Ensure the page that loads the tutorial layour works correctly (http://localhost:4321/ccip/tutorials/evm/cross-chain-tokens/register-from-eoa-remix)
Zelig880
approved these changes
Oct 14, 2025
Zelig880
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work
Zelig880
added a commit
that referenced
this pull request
Nov 26, 2025
* Feat/82 update packages (#94) * chore: add blocks package * feat: install tailwind * chore: install tailwind v3 * fix: remove autoprefixer * Restore package-lock * fix: disable preflight * Feat/83 remove secondary header (#95) * Remove DocsNavigation from DocsLayout. Update styling to accomodate. * fix: adjust left grid sticky and padding * Update leftSidebar.module.css * fix: remove docs from tutoriallayout * checkpoint: added block styling * Update left sidebar style and add quick links * remove bg from left sidebar * remove additional links from right sidebar * fix styling * fix tailwind rendering for blocks components. spot fix styling overrides from tailwind * Update docsHeaderTitle.module.css * Update leftSidebar.module.css * Update LeftSidebar.astro * Update PageContent.astro * Update DocsHeaderTitle.astro * Adds DocsV3Layout skeleton (#102) * fix spacing * Feat: Add cards (#101) * add cards * update styling * adjust types * fix heading * cleanup grid styling * Feat/93 layout tutorials (#104) * add tutorial foundation * Add tutorial components * add README * support N number of columns and add arrow icon * Update index.astro * remove unused import * Update GridCard.module.css * change how we add borders * make grid responsive --------- Co-authored-by: Simone Cuomo <simone@thisdot.co> * Feat/91 layout hero (#103) * add layout hero * use button component styles for the button links * removing unused styles * Feat/108 info tab (#120) * add info card * Update QuickLinkCard.module.css * Update QuickLinkCard.module.css * Feat/112 image (#118) * add media structure * Create README.md --------- Co-authored-by: Simone Cuomo <simone@thisdot.co> * Add resources grid (#117) * add resources grid * adjust image linking --------- Co-authored-by: Simone Cuomo <simone@thisdot.co> * Feat/110 tools utilities (#116) * add grid * Update DocsV3Layout.astro * Update DocsV3Layout.astro * rwd * Update DocsV3Layout.astro * Update DocsV3Layout.astro * Update ToolsUtilitiesGrid.astro * add readme --------- Co-authored-by: Simone Cuomo <simone@thisdot.co> * Feat/make overview page (#122) * move all new components to overview (index mdx) page * fix css rule * update example links to real links * fix linkchecker * Feat/115 mobile components (#119) * RWD layout hero * RWD cards and tutorials * improve mobile spacing * fix tab trigger jump * Add chainlink journey (#133) * add journey cards * move components --------- Co-authored-by: Simone Cuomo <simone@thisdot.co> * Feat/127 tech standards (#134) * add journey cards * add tech standards * Update TechnicalStandards.astro * Update TechnicalStandards.astro * Update TechnicalStandards.astro * Update TechnicalStandards.astro * Feat/128 demos (#136) * add demos * add hover effects * update styling * wrap up * fixes merge conflicts * add anchor tags * Feat/114 changelog (#135) * add changelog stylin and elements * Add footer masking * Update ChangelogCard.module.css * mobile improvements * Update ChangelogCard.astro * wrap up * add prop for query * add README * add fade to show more * Update ChangelogSnippet.astro * add query types * fix merge conflicts * Update ChangelogSnippet.astro * clarify comment * add mobile journeys (#141) * add mobile journeys * remove old grid card css * Feat/86 megamenu (#137) * add basic megamenu structure and add missing icons * update megamenu desktop design * Update MegaMenu.tsx * Feat/85 hero (#132) * add hero * fix styling * fix css issue on dropdown menu * Update ProductNavigation.tsx * Update landingHero.module.css * add truncate * fix some styling * cleaned up old components and fixed some mobile styling * format megamenu and remove dead code * Update productNavigation.module.css * Update index.astro * Feat/129 community (#143) * html foundation * finish * Update CommunityEvents.module.css * Update CommunityEvents.astro * update styling * Update fetchEvents.ts * Update CommunityEvents.astro * Update CommunityEvents.module.css * Add get certified page (#151) * add certified base * Update certification.astro * Update certification.astro * Update certification.astro * Update certification.astro * update colour token * Update ProductNavigation.tsx * Feat/130 try it (#142) * add component * styling * update try it out component * Update MegaMenu.tsx * wrap up tryit * add README * Update TryItOutAccordion.tsx * add dynamic code samples and accordian control * prerender code * Update CodeSampleReact.tsx * Update styles.module.css --------- Co-authored-by: Simone Cuomo <simone@thisdot.co> * Support video in resources section (#147) * support video * Update ResourceCard.astro * Update ResourceCard.astro * Update Package.json * Fixes from merge with main (#165) * fixes from merge with main * fix directory header * Update Package.json after merge --------- Co-authored-by: Tyrel Chambers <tychambers3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.Any change needs to be discussed before proceeding.
Closing issues
closes #83
...
Description
Go to the Docs page and see the secondary header removed. You can also see it exists on the CCIP directory page (pending CL decision on whether or not to remove it from there too). Some logic exists to support the SecondaryHeader on the CCIP Directory page
Changes
Screen.Recording.2025-10-07.at.12.20.33.PM.mov