Feature/load event #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackhkmatthews
force-pushed
the
feature/load-event
branch
3 times, most recently
from
9e22532 to
6e868c7
Compare
edoparearyee
previously requested changes
Dec 12, 2017
e2e/app.e2e-spec.ts
Outdated
|
|
||
| }); | ||
|
|
||
| describe('iamge loaded', () => { |
src/app/app.component.ts
Outdated
| * Incremented on each image load event. | ||
| * | ||
| * @type {number} | ||
| * @memberof ImageLoaderComponent |
There was a problem hiding this comment.
i think this should be AppComponent
| (inViewportChange)="onInViewportChange($event)" | ||
| [debounce]="0"> | ||
| [debounce]="0" | ||
| (load)="onImageLoad(image)"> |
There was a problem hiding this comment.
I think the argument for the event handler needs to be $event like on line 8
| * @memberof ImageLoaderComponent | ||
| */ | ||
| public onImageLoad(image: ResponsiveImage): void { | ||
| this.imageLoaded.emit(image); |
There was a problem hiding this comment.
I was thinking do we need to emit the image load event when the placeholder is loaded? is it useful?
jackhkmatthews
force-pushed
the
feature/load-event
branch
from
6e868c7 to
43e7e1d
Compare
… use by the image loader compon
…nt added for placeholder image BREAKING CHANGE: The inputs and outputs to the image-loader component have changed
…ader component to match updated BREAKING CHANGE: image-loader components updated inputs and outputs implemented
…mage-loader component functiona
jackhkmatthews
dismissed
edoparearyee’s stale review
comments have been addressed
…e by srcSet attribute. Prevents tests from running before the next image is loaded.
edoparearyee
previously requested changes
Dec 13, 2017
src/app/app.component.html
Outdated
| imgClass="foo" | ||
| alt="lorem ipsum" | ||
| (placeholderLoaded)="onPlaceholderLoad($event)" | ||
| (fullResLoaded)="onFullResLoad($event)" |
There was a problem hiding this comment.
I would be very clear and specific and call these events imageLoaded and imagePlaceholderLoaded as fullResLoaded sounds ambiguous
| * @memberof ImageLoaderComponent | ||
| */ | ||
| @Output() | ||
| public fullResLoaded: EventEmitter<ImageLoadedEvent> = new EventEmitter<ImageLoadedEvent>(); |
There was a problem hiding this comment.
Same here i would be clear and specific and call this imageLoaded
…fullResLoaded updated to imageL BREAKING CHANGE: Variable name changes affect the image-loader component API
jackhkmatthews
dismissed
edoparearyee’s stale review
Suggestions implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
imageLoadedevent chain