Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRCv3 capability negotiation and tag parsing #94

Merged
merged 2 commits into from Oct 13, 2017

Conversation

@russss
Copy link
Contributor

commented Jan 25, 2017

This adds the ability to negotiate arbitrary IRCv3 capabilities on connection, in accordance with the IRCv3.1 Client Capability Negotiation spec. Capabilities to be requested can be set in irc.RequestCaps, and after registration the negotiated capabilities can be seen in irc.AcknowledgedCaps.

It also adds support for IRCv3.2 message tags to the event parser.

Ref: issue #34

russss added 2 commits Jan 25, 2017
This adds the ability to negotiate arbitrary IRCv3 capabilities on
connection. Capabilities to be requested can be set in `irc.RequestCaps`,
and after registration the negotiated capabilities can be seen in
`irc.AcknowledgedCaps`.
@vallard192

This comment has been minimized.

Copy link

commented Oct 13, 2017

Is this PR waiting on anything in particular? Would love to see it merged.

@thoj thoj merged commit ef65ae6 into thoj:master Oct 13, 2017
@thoj

This comment has been minimized.

Copy link
Owner

commented Oct 13, 2017

Just forgot about this. Sorry 🙄

@vallard192

This comment has been minimized.

Copy link

commented Oct 13, 2017

No worries at all and thanks! Loving the library so far.

@Habbie

This comment has been minimized.

Copy link

commented Feb 18, 2019

Note: using this negotiation breaks the SASL support from #77 - the AUTHENTICATE PLAIN command will be sent multiple times, and eventually the server ends up treating PLAIN as the authentication data, which of course does not match your username and password.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.