3.2.24_rc1 - link_policy missing nl_ prefix on export #52

Closed
kwhat opened this Issue Dec 23, 2013 · 1 comment

Projects

None yet

2 participants

kwhat commented Dec 23, 2013

See:

https://bugzilla.gnome.org/show_bug.cgi?id=720902
https://bugs.gentoo.org/show_bug.cgi?id=494890

nm-ip6-manager.c:1262:26: error: static declaration of 'link_policy' follows
non-static declaration
static struct nla_policy link_policy[IFLA_MAX + 1] = {
^
In file included from /usr/include/libnl3/netlink/route/addr.h:20:0,
from nm-ip6-manager.c:28:
/usr/include/libnl3/netlink/route/link.h:101:26: note: previous declaration of
'link_policy' was here
extern struct nla_policy link_policy[];
^
Makefile:526: recipe for target 'libip6_manager_la-nm-ip6-manager.lo' failed
make[4]: *** [libip6_manager_la-nm-ip6-manager.lo] Error 1
make[4]: Leaving directory
'/var/tmp/portage/net-misc/networkmanager-0.9.8.8/work/NetworkManager-0.9.8.8/src/ip6-manager'
Makefile:1721: recipe for target 'all-recursive' failed
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory
'/var/tmp/portage/net-misc/networkmanager-0.9.8.8/work/NetworkManager-0.9.8.8/src'
Makefile:813: recipe for target 'all' failed
make[2]: *** [all] Error 2
make[2]: Leaving directory
'/var/tmp/portage/net-misc/networkmanager-0.9.8.8/work/NetworkManager-0.9.8.8/src'
Makefile:650: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
'/var/tmp/portage/net-misc/networkmanager-0.9.8.8/work/NetworkManager-0.9.8.8'
Makefile:542: recipe for target 'all' failed
make: *** [all] Error 2

@thom311 thom311 was assigned Jan 2, 2014
@thom311 thom311 added a commit that referenced this issue Jan 2, 2014
@thom311 route: add libnl name prefix to global variable link_policy
Public names should be prefixed with a libnl specific
prefix to avoid name collisions. Rename link_policy to
rtln_link_policy.

Related bugs:
  #52
  https://bugzilla.gnome.org/show_bug.cgi?id=720902
  https://bugs.gentoo.org/show_bug.cgi?id=494986
  https://bugs.gentoo.org/show_bug.cgi?id=494890

Signed-off-by: Thomas Haller <thaller@redhat.com>
2cf635b
Owner
thom311 commented Jan 2, 2014

Fixed in commit 2cf635b by renaming variable link_policy

@thom311 thom311 closed this Jan 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment