Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding line numbers and line highlighting plugins #2

Open
lask79 opened this issue Apr 29, 2019 · 6 comments
Open

Adding line numbers and line highlighting plugins #2

lask79 opened this issue Apr 29, 2019 · 6 comments

Comments

@lask79
Copy link

lask79 commented Apr 29, 2019

Hi,

is it possible you also integrate the line number and line highlighting plugins?

Regards
Lasse

@thom4parisot
Copy link
Owner

You mean the prism plugins?

Can I find them on the prism website or do you think of something else?

Also, if you have a picture of what you expect to see when both plugins are enabled, feel free to share it so as I can ensure I do things properly.

Thanks for raising this issue 👍

@thom4parisot
Copy link
Owner

I guess you refer to:

They are not CommonJS nor ESM modules so it will require some tooling to integrate them with this Asciidoctor plugin.

One thing I'm not sure too, is how to match the line numbers of partially included files. I still need to figure that out.

@thom4parisot
Copy link
Owner

After investigation with @Mogztter, we found out there are 2 ways of doing things:

  • exposing the assets on the client-side as some operations are performed in the DOM (they add new divs etc.)
  • mimicking the DOM structure on the server-side (client-side is JavaScript-less but the logic has to be reimplemented)

@lask79 what do you think?

@lask79
Copy link
Author

lask79 commented May 9, 2019

What do you prefer? What would be the easiest solution for you and usable for others?

Regards
Lasse

@wouter-veeken
Copy link

Any progress on this? Would love to see this implemented 👍

@snowe2010
Copy link

I also am coming here for this. I'm using antora and apparently can't use the built in syntax highlighters to support line highlighting, so need to find an alternative. Prism looks perfect, but this is the only reason for me to switch libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants