[Develop] Fix: multisite admin menu and notices #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 13, 2015
|
Would you mind creating this pull request against the master branch? I've not done anything with the develop branch in a while. Indeed, I need to actually remove it as it doesn't quite make sense for this repo. |
jrfnl
changed the title
As the notices are now only shown on network admin for multisite, thickbox does not need to be loaded on single sites in a multi-site context.
|
Not ready for merge yet - please see note in the sister-PR: #252 (comment) |
|
Since the sister-PR branch has been deleted, is this PR closeable for now? |
|
Sister-PR branch has been deleted as it was against master and this should be dealt with in dev first. This issue will be tackled in v3.0. I suggest we keep it open until the issue/PR for v3 has been posted and reference this PR in that issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As on multisite by default plugins can only be installed from the network admin, it makes more sense showing the TGM page in the network admin and not in the site admin.
On that same note, the admin notices should be shown on the network admin too.
Related issues: #228, #239