Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate `*All` helpers for better ergononmics #36
Conversation
thomashoneyman
self-assigned this
Oct 23, 2018
thomashoneyman
merged commit 225dd6c
into
master
Oct 24, 2018
1 check passed
ci/circleci: test
Your tests passed on CircleCI!
Details
thomashoneyman
deleted the
query-update
branch
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
thomashoneyman commentedOct 23, 2018
•
edited
What does this pull request do?
Updates the
setAll,modifyAll,setValidateAll, andmodifyValidateAllquery helpers (adding the last two as brand-new ones) so that they don't force users to wrap their input records when passing them. This brings them in line with the other query helpers likesetandmodifyand reduces boilerplate.Other Notes:
This breaks the 0.3.0 API for these helpers and will require a bump to 0.4.0.