Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Formless component template file #53
What does this pull request do?
Where should the reviewer start?
Read the 'other notes' section, skim the code and then answer my questions below
How should this be manually tested?
AFAIK, we should only verify that this code compiles in the CI.
There's a number of things that aren't correct in this PR with regard to the data type,
The halogen component part is basically the uncommented version of the template file. Since it's also lacking in a few other ways (more modular pieces that show how to use some of its API?), it would need to be completed before we could document it better. I'm not sure what should be included here and what should be left out because the
Questions I have:
Lastly, there's documenting each part in a clear manner.
JordanMartinez left a comment
I'm not sure what you had in mind for adding comments to each part, but this is what I would put. Feel free to correct/revise, etc. and I'll update it to what we agree upon here and push the changes following that.