New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/disable scheduling #73
Feature/disable scheduling #73
Conversation
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
============================================
- Coverage 97.26% 97.24% -0.03%
- Complexity 80 81 +1
============================================
Files 10 10
Lines 256 254 -2
============================================
- Hits 249 247 -2
Misses 7 7
Continue to review full report at Codecov.
|
Thanks, I've made those changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments, looks good though :)
Your description is much clearer than mine, but is exactly what I wanted. Appreciate you doing this. |
Also appreciate the package, our app uses this to send over 200 scheduled notifications per day. Feel free to merge in when you can. |
(you didn't tick the box to allow me to change your PR, so you'll need to commit those changes :)) |
Co-authored-by: atymic <atymicq@gmail.com>
I think this is related to my issue #78 |
@gborcherds How do you update vendor files? Using something like cweagans/composer-patches ? |
@atymic @gborcherds This PR introduced a situation where when snooze is disabled, but a pruneAge is set, then the package is in an error state. The culprit is this bit of code in the provider: if (! config('snooze.disabled')) {
$frequency = config('snooze.sendFrequency', 'everyMinute');
$schedule = $this->app->make(Schedule::class);
$schedule->command('snooze:send')->{$frequency}();
}
if (config('snooze.pruneAge') !== null) {
$schedule->command('snooze:prune')->daily();
} The I've made a pr to address this here #84 |
Co-authored-by: atymic <atymicq@gmail.com>
Feel free to not accept this, but I have need of being able to turn off the automatic scheduling. I have shared models across multiple repos and I only need the scheduling to run in one repo.