Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getCardSize Implementation #11

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@jblancoperez
Copy link

jblancoperez commented Mar 13, 2019

When using state-switch.js came across a problem when an auto-entities card was used.

Auto-entities provides no implementation of getCardSize, which state-switch uses in the logic of reporting the "biggest" entity across all states.

I thought that auto-entities reporting the inner card size was useful for other cases too.

think about it, If you prefer to alter state-switch implementation I undestand.

Thanks,

Show resolved Hide resolved auto-entities.js Outdated

@jblancoperez jblancoperez force-pushed the jblancoperez:master branch from 308788b to 6a0b5cd Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.