Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facet_wrap_paginate #7

Closed
guiastrennec opened this issue Sep 25, 2016 · 10 comments
Closed

facet_wrap_paginate #7

guiastrennec opened this issue Sep 25, 2016 · 10 comments
Labels

Comments

@guiastrennec
Copy link

@guiastrennec guiastrennec commented Sep 25, 2016

Nice work on ggforce and looking forward to the new release with ggplot2 2.2.0. In the meantime 2 questions on facet_wrap_paginate:

  • Is it possible to print all pages at once without using the for loop?
  • Is it possible to keep the requested layout e.g. ncol = 2, nrow = 2 on the last page even if there is in this case only 2 panels left to plot?
@thomasp85

This comment has been minimized.

Copy link
Owner

@thomasp85 thomasp85 commented Sep 26, 2016

Good questions :-)

For the first - I plan to provide some sort of helper function that facilitates this, but it will not be part of facet_*_paginate itself. For the second, this is something I've thought about too, without prioritising it a lot so it is not part of the current implementation. I'll not rule it out though...

@daattali

This comment has been minimized.

Copy link

@daattali daattali commented Nov 11, 2016

ggplot2.2.0 is out! Can we have this feature now pretty please? :)

@thomasp85

This comment has been minimized.

Copy link
Owner

@thomasp85 thomasp85 commented Nov 11, 2016

It has not even been a day...:-)

@daattali

This comment has been minimized.

Copy link

@daattali daattali commented Nov 11, 2016

But it's been well over a minute. What am I paying you for!

(take your time, just wanted to place a reminder because I'm sure you have a lot of different projects going on and this one might not be a priority that's on your mind)

@thomasp85

This comment has been minimized.

Copy link
Owner

@thomasp85 thomasp85 commented Nov 11, 2016

Believe it or not but ggforce and ggraph are currently on top of my "projects-I-do-and-enjoy". Thus below leftover PhD articles and the work that puts bread on the table, but above the rest you find on my GitHub profile

@thomasp85 thomasp85 added the feature label Nov 22, 2016
@mthernando

This comment has been minimized.

Copy link

@mthernando mthernando commented Nov 26, 2016

Thanks Thomas for your great work! I am using facet_wrap_paginate and it works OK with the first page, but when trying to print the second one it fails with the following error.

plot_bar(taxa.norm_phylum, "Substrate", fill='SampleID', title='Phylum relative abundance -Substrate-')+geom_bar(stat='identity', position='stack')+facet_wrap_paginate(~Phylum, ncol = 3, nrow=3, scales = 'free', page = 2)
Error in FUN(X[[i]], ...) : Unknown input

Could you please help to me? (I've updated the package to the latest version, released just 17h ago)

Thanks

María

@thomasp85

This comment has been minimized.

Copy link
Owner

@thomasp85 thomasp85 commented Nov 26, 2016

Whst is plot_bar? It is not part of either ggplot2 or ggforce...

@mthernando

This comment has been minimized.

Copy link

@mthernando mthernando commented Nov 26, 2016

Sorry, this is from phyloseq package, that use ggplot2 to plot several objects built from metagenomic studies. I have used phyloseq functions + ggplot2 options and it works properly, but I didn't realized that perhaps in this case it does not work.

@thomasp85

This comment has been minimized.

Copy link
Owner

@thomasp85 thomasp85 commented Nov 26, 2016

It could be - phyloseq is probably optimised to work correctly with ggplot2 functions. If you can reproduce the error with pure ggforce/ggplot2 calls I'll look into it. Otherwise I suggest contacting the authors of phyloseq

@mthernando

This comment has been minimized.

Copy link

@mthernando mthernando commented Nov 26, 2016

Yes, it works properly with ggplot2, and it seems to fail with phyloseq. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.