Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up dendrogram layout computation #248

Closed
andremrsantos opened this issue Jun 4, 2020 · 0 comments
Closed

Speed up dendrogram layout computation #248

andremrsantos opened this issue Jun 4, 2020 · 0 comments

Comments

@andremrsantos
Copy link

Hi,

I've recently been working with the package for plotting some tree and dendrogram data, but some of my trees are quite large, and computing their layout is becoming costly.

Reviewing the code, I notice the following line of code used to compute the nodes' position.

full_lengths <- distances(graph, to = node_is_root(), weights = length)

I was wondering if you couldn't include the parameter mode = "in" to avoid the algorithm transverse the whole tree and reduce computing time? I did a quick test and it improved the execution time for my local function.

Thanks for everything and a great project 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant