Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding geom_edge_parallel (#44) #191

Merged
merged 6 commits into from
Aug 15, 2019
Merged

adding geom_edge_parallel (#44) #191

merged 6 commits into from
Aug 15, 2019

Conversation

schochastics
Copy link
Contributor

@schochastics schochastics commented Aug 14, 2019

Fixes #44

I have tried to understand cappedPath.R and the makeContent thing, but I have to admit that this is above my pay grade.

So this is the geom version that draws parallel edges "one level to high".
parallel edges are calculated in create_parallels(). The function edge_shift() spreads edges evenly so that the distance between edges is always the same, no matter how many multi edges exist.

The function creates a warning about unknown from and to parameters. I had to add them to
aes_intersect (line 128) to identify the multi edges but couldn't figure out how to revert back again.

The other code is a straightforward adoption of geom_edge_link()

I did not implement geom_edge_parallel0() and geom_edge_parallel2().

Hope this helps you in any way. Just decline if not.

@thomasp85
Copy link
Owner

Thank you — I’ll have a go with this once I’m done with the BioFabric layout

@thomasp85
Copy link
Owner

If you want you can look through the changes to see what it took - I admit it was a bit hairy :-)

@thomasp85 thomasp85 merged commit bdecc99 into thomasp85:master Aug 15, 2019
@schochastics
Copy link
Contributor Author

yep as I expected. Way beyond my skills. Thanks for considering my code. I learned a thing or two in the process :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallel links for edges that go in both directions
2 participants