Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on parseSavePath when UI does not have filetype #47

Merged
merged 2 commits into from Apr 29, 2017

Conversation

@zeehio
Copy link
Contributor

@zeehio zeehio commented Oct 2, 2016

This PR closes #45.

I have not created a test but simply by removing the filetype=list(text='txt', picture=c('jpeg', 'jpg')) argument from the inst/example/ui.R file, running the app and trying to use the save file button can reproduce the error, and it is fixed after applying this patch.

Thanks for your time with this package!

@zeehio zeehio force-pushed the zeehio:fix_45 branch from 375cd15 to 51b89e6 Oct 2, 2016
@codecov-io
Copy link

@codecov-io codecov-io commented Oct 2, 2016

Current coverage is 0.00% (diff: 0.00%)

Merging #47 into master will not change coverage

@@           master   #47   diff @@
===================================
  Files           4     4          
  Lines         309   315     +6   
  Methods         0     0          
  Messages        0     0          
  Branches        0     0          
===================================
  Hits            0     0          
- Misses        309   315     +6   
  Partials        0     0          

Powered by Codecov. Last update e354fe5...51b89e6

@thomasp85 thomasp85 merged commit 0482338 into thomasp85:master Apr 29, 2017
3 checks passed
3 checks passed
codecov/patch 0.00% of diff hit (target 0.00%)
Details
codecov/project 0.00% (+0.00%) compared to e354fe5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@thomasp85
Copy link
Owner

@thomasp85 thomasp85 commented Apr 29, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants