New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding issue with .navbar-brand #388

Closed
rdahbura opened this Issue Jan 18, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@rdahbura

rdahbura commented Jan 18, 2015

The bootswatch.less file includes a modification to the padding on the .navbar-brand class that causes the vertical padding to be asymmetrical when changing the base font size. It becomes especially noticeable when reducing the font size. The lines are:

&-brand {
padding: 18.5px 15px 20.5px;
}

The bootstrap theme includes a calculation based on line height and font size that keeps the brand centered vertically. I'm not sure why it's being overridden but it would be nice to remove that, assuming the above explanation makes sense.

Thanks.

@hebbet

This comment has been minimized.

Show comment
Hide comment
@hebbet

hebbet Jan 20, 2015

Contributor

Maybe you make a pull request :)
Not sure what themes you mean

Contributor

hebbet commented Jan 20, 2015

Maybe you make a pull request :)
Not sure what themes you mean

@thomaspark

This comment has been minimized.

Show comment
Hide comment
@thomaspark

thomaspark Jan 23, 2015

Owner

This is mainly an issue with Flatly and Darkly. Getting rid of hard-coded values.

Owner

thomaspark commented Jan 23, 2015

This is mainly an issue with Flatly and Darkly. Getting rid of hard-coded values.

@rdahbura

This comment has been minimized.

Show comment
Hide comment
@rdahbura

rdahbura Jan 23, 2015

Great! Thank you!

rdahbura commented Jan 23, 2015

Great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment