Avoid a warning from the byte-compiler

There are two options available (1) define `js3-mode-error' and its
alias `js3-mode-help' before using them, or (2) quote the function
symbol using `quote' instead of `function' (' instead of #').

We do the latter here.  The result is that the byte-compiler no longer
knows that these function symbols are intended to be used as functions,
so it no longer checks whether these functions are defined, so it no
longer detects that this may not be the case, and does not complain.
That's okay.  The functions are being defined, just after they are being
defined.

Also note that quoting the first symbol in a `defalias' form as a
function is never right.  When `defalias' arguments are being evaluated
the alias (i.e. the function) is not defined yet, that's why we call it.

js3-mode.el

@@ -7176,7 +7176,7 @@ it is considered declared."
                                       (js3-get-defining-scope scope name))
                             (js3-set-face pos end 'js3-external-variable-face 'record)
                             (js3-record-text-property pos end 'help-echo "Undeclared variable")
-                            (js3-record-text-property pos end 'point-entered #'js3-echo-help))))
+                            (js3-record-text-property pos end 'point-entered 'js3-echo-help))))
     (setq js3-recorded-identifiers nil)))
 
 (provide 'js3-highlight)
@@ -11040,7 +11040,7 @@ This ensures that the counts and `next-error' are correct."
                (not (current-message)))
       (message msg))))
 
-(defalias #'js3-echo-help #'js3-echo-error)
+(defalias 'js3-echo-help #'js3-echo-error)
 
 (defun js3-enter-key ()
   "Handle user pressing the Enter key."

lib/js3-foot.el

@@ -339,7 +339,7 @@ This ensures that the counts and `next-error' are correct."
                (not (current-message)))
       (message msg))))
 
-(defalias #'js3-echo-help #'js3-echo-error)
+(defalias 'js3-echo-help #'js3-echo-error)
 
 (defun js3-enter-key ()
   "Handle user pressing the Enter key."

lib/js3-highlight.el

@@ -447,7 +447,7 @@ it is considered declared."
                                       (js3-get-defining-scope scope name))
                             (js3-set-face pos end 'js3-external-variable-face 'record)
                             (js3-record-text-property pos end 'help-echo "Undeclared variable")
-                            (js3-record-text-property pos end 'point-entered #'js3-echo-help))))
+                            (js3-record-text-property pos end 'point-entered 'js3-echo-help))))
     (setq js3-recorded-identifiers nil)))
 
 (provide 'js3-highlight)