Merged
Conversation
thomcc
approved these changes
Nov 17, 2021
Owner
thomcc
left a comment
thomcc
left a comment
There was a problem hiding this comment.
LGTM, I'll do a release later today.
Owner
|
Hm, I guess bumping to 0.2.2 would bump the msrv (to whenever no_std was added), although at this point it's still old enough not to matter... |
Owner
|
Nevermind, published as v0.2.2. |
Contributor
Author
|
Thanks! I agree, I don't think that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sumary
In short, this crate already is no_std compatible, it just doesn't declare no_std in the root
lib.rs. Adding thatno_stddeclaration makes it usable in no_std projects.Motivation
This crate is used widely in the
wasmtimeproject, among others, which currently doesn't support no_std. However, I along with others are working to port it to no_std environments, and this crate is part of the puzzle.